Bug 254740 - astro/py-spktype01: "NUMPY" Makefile variable empty, breaks "synth status-everything"
Summary: astro/py-spktype01: "NUMPY" Makefile variable empty, breaks "synth status-eve...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-03 10:52 UTC by Bojan Petrovic
Modified: 2021-04-07 15:07 UTC (History)
1 user (show)

See Also:
thierry: maintainer-feedback+


Attachments
Makefile patch (370 bytes, patch)
2021-04-03 10:52 UTC, Bojan Petrovic
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bojan Petrovic 2021-04-03 10:52:53 UTC
Created attachment 223784 [details]
Makefile patch

I ran "synth status-everything" and got:

    culprit: astro/py-spktype01@py37
      Scan aborted because dependency is malformed.
      RUNTIME: 	 py37-jplephem>0:astro/py-jplephem@py37 py37-setuptools>0:devel/py-setuptools@py37 /usr/local/bin/python3.7:lang/python37 (astro/py-spktype01@py37)
    Failed to scan ports tree   (Synth must exit)

This issue occurs with astro/py-spktype21 also.

I believe this happens because of the leading tab in "make -VRUN_DEPENDS":

    	 py37-jplephem>0:astro/py-jplephem@py37 py37-setuptools>0:devel/py-setuptools@py37 /usr/local/bin/python3.7:lang/python37


The leading tab is there because Makefile contains


RUN_DEPENDS=	${NUMPY}	\
    		${PYTHON_PKGNAMEPREFIX}jplephem>0:astro/py-jplephem@${PY_FLAVOR}

but the NUMPY variable is empty, and the tab character follows it.

I believe "NUMPY" should be replaced with "PYNUMPY".

These are the ports mentioning "NUMPY":

astro/py-spktype01
astro/py-jplephem
astro/py-spktype21
science/py-PyFR
science/py-chempy
math/py-seaborn
Comment 1 Thierry Thomas freebsd_committer 2021-04-03 13:14:45 UTC
You´re right, thanks!

Without synth it does not break, but the dependency on numpy is missing.

To be committed as soon as the ports tree will return in write mode (post git-migration).
Comment 2 Thierry Thomas freebsd_committer 2021-04-07 15:07:05 UTC
Committed, thanks!
Comment 3 commit-hook freebsd_committer 2021-04-07 15:07:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c71776b7673dd9fcbc84a187f2c76ab813f939f5

commit c71776b7673dd9fcbc84a187f2c76ab813f939f5
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2021-04-07 14:25:15 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2021-04-07 15:05:55 +0000

    astro/py-spktype01 et al.: fix the dependency on PYNUMPY

    Some ports, like astro/py-spktype01, uses the undefined variable ${NUMPY}
    in their _DEPENDS fields and this must be replaced by the correct
    ${PYNUMPY}.

    PR:             254740
    Reported by:    Bojan Petrovic
    Approved by:    QA blanket for the ports that I do not maintain

 astro/py-jplephem/Makefile  | 5 +++--
 astro/py-spktype01/Makefile | 5 +++--
 astro/py-spktype21/Makefile | 5 +++--
 math/py-seaborn/Makefile    | 3 ++-
 science/py-PyFR/Makefile    | 3 ++-
 science/py-chempy/Makefile  | 3 ++-
 6 files changed, 15 insertions(+), 9 deletions(-)