Created attachment 223946 [details]
XDG_RUNTIME_DIR may be pointed to a filesystem that doesn't support posix_fallocate() (e.g. ZFS). Running the xkbcli interactive-wayland keymap test then fails. The following patch fixes this use case. I plan to send it upstream this week.
Reviewed by: jbeich@, zeising@ (via Gitter)
Inspired by: https://gitlab.freedesktop.org/wayland/wayland/-/blob/1.19.0/cursor/os-compatibility.c#L168-178
Created attachment 223954 [details]
clean/simplify, sorry for the noise
Created attachment 224105 [details]
v3 was discussed with upstream by email (not mailing list because issues with wayland-devel mailing list)...
Upstream commit states "Idea by" instead of "Reviewed by"; I forgot what I initially left here when I was filling git commit... This will not repeat again, sorry.
Leaving here the output of git format-patch, add appropriate lines to credit jbeich@ and zeising@ as you wish.
This should be in a new release.
Thanks for upstreaming. It's hard work and very much appreciated i.e., reduces review/maintenance load on ports/ committers.
(In reply to Evgeniy Khramtsov from comment #2)
> Upstream commit states "Idea by" instead of "Reviewed by";
This is actually correct. I didn't review the last version.
A commit in branch main references this bug:
Author: Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-05-01 21:00:07 +0000
Commit: Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-05-13 21:16:15 +0000
x11/libxkbcommon: update to 1.3.0
PR: 254919 255768
Approved by: manu
Differential Revision: https://reviews.freebsd.org/D30118
x11/libxkbcommon/Makefile | 2 +-
x11/libxkbcommon/distinfo | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)