Bug 254919 - x11/libxkbcommon: fix xkbcli interactive-wayland when posix_fallocate() isn't supported by fs
Summary: x11/libxkbcommon: fix xkbcli interactive-wayland when posix_fallocate() isn't...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords: patch
Depends on: 255768
Blocks:
  Show dependency treegraph
 
Reported: 2021-04-09 14:17 UTC by Evgeniy Khramtsov
Modified: 2021-05-13 21:18 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (x11)


Attachments
patch (1.04 KB, patch)
2021-04-09 14:17 UTC, Evgeniy Khramtsov
no flags Details | Diff
v2 (1.05 KB, patch)
2021-04-09 20:23 UTC, Evgeniy Khramtsov
no flags Details | Diff
v3 (1.68 KB, patch)
2021-04-14 12:47 UTC, Evgeniy Khramtsov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evgeniy Khramtsov 2021-04-09 14:17:56 UTC
Created attachment 223946 [details]
patch

XDG_RUNTIME_DIR may be pointed to a filesystem that doesn't support posix_fallocate() (e.g. ZFS). Running the xkbcli interactive-wayland keymap test then fails. The following patch fixes this use case. I plan to send it upstream this week.

Reviewed by: jbeich@, zeising@ (via Gitter)
Inspired by: https://gitlab.freedesktop.org/wayland/wayland/-/blob/1.19.0/cursor/os-compatibility.c#L168-178
Comment 1 Evgeniy Khramtsov 2021-04-09 20:23:55 UTC
Created attachment 223954 [details]
v2

clean/simplify, sorry for the noise
Comment 2 Evgeniy Khramtsov 2021-04-14 12:47:43 UTC
Created attachment 224105 [details]
v3

v3 was discussed with upstream by email (not mailing list because issues with wayland-devel mailing list)...

Upstream commit states "Idea by" instead of "Reviewed by"; I forgot what I initially left here when I was filling git commit... This will not repeat again, sorry.

Leaving here the output of git format-patch, add appropriate lines to credit jbeich@ and zeising@ as you wish.
Comment 3 Evgeniy Khramtsov 2021-04-27 22:33:30 UTC
This should be in a new release.
Comment 4 Jan Beich freebsd_committer 2021-04-30 11:06:42 UTC
Thanks for upstreaming. It's hard work and very much appreciated i.e., reduces review/maintenance load on ports/ committers.

(In reply to Evgeniy Khramtsov from comment #2)
> Upstream commit states "Idea by" instead of "Reviewed by";

This is actually correct. I didn't review the last version.
Comment 5 commit-hook freebsd_committer 2021-05-13 21:18:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2e003fef2f7dde3ead6d36f4ed4d34535f6114b6

commit 2e003fef2f7dde3ead6d36f4ed4d34535f6114b6
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-05-01 21:00:07 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-05-13 21:16:15 +0000

    x11/libxkbcommon: update to 1.3.0

    Changes:        https://lists.freedesktop.org/archives/wayland-devel/2021-May/041816.html
    PR:             254919 255768
    Approved by:    manu
    Differential Revision:  https://reviews.freebsd.org/D30118

 x11/libxkbcommon/Makefile | 2 +-
 x11/libxkbcommon/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)