Bug 255062 - graphics/libgphoto2: append ${PREFIX}/include to clfags in gphoto2-config
Summary: graphics/libgphoto2: append ${PREFIX}/include to clfags in gphoto2-config
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL: https://github.com/gphoto/libgphoto2/...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-14 19:15 UTC by Tobias C. Berner
Modified: 2021-05-31 17:27 UTC (History)
3 users (show)

See Also:


Attachments
v1 (1.78 KB, patch)
2021-04-14 19:15 UTC, Tobias C. Berner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias C. Berner freebsd_committer 2021-04-14 19:15:04 UTC
Created attachment 224113 [details]
v1

Moin moin 

KDE's CI noticed [1] an issue in the shipped gphoto2-config tool of this port.

    At the moment:
            > pkgconf --cflags libgphoto2
            -I/usr/local/include/gphoto2 -I/usr/local/include

    Whereas
            > gphoto2-config  --cflags
            -I/usr/local/include/gphoto2

    This means that software using gphoto2 via the shipped gphoto2-config
    tool will also require USES=localbase (see graphics/kamera).

    The patch attached appends ${PREFIFX}/include to the config tool, making
    it also output

            > gphotot2-config --cflags
            -I/usr/local/include/gphoto2-I/usr/local/include


[probably should be tested against all dependencies though :)].


mfg Tobias


[1] https://build.kde.org/view/Failing/job/Applications/job/kamera/job/stable-kf5-qt5%20FreeBSDQt5.15/23/console
Comment 1 Ben Woods freebsd_committer 2021-05-22 02:25:04 UTC
Sorry, due to a lack of time I have reset the maintainer of this port back to ports@FreeBSD.org. Hopefully someone else is able to step in to help.
Resetting the assignee of this bug accordingly.
Comment 2 Alexey Dokuchaev freebsd_committer 2021-05-24 06:34:16 UTC
(In reply to Tobias C. Berner from comment #0)
> The patch attached appends ${PREFIFX}/include to the config tool
I'm actually not sure why -I/usr/local/include/gphoto2 needs to be returned at all, as all libgphoto2 consumers I've encountered include its header files relative to ${PREFIX}/include.  I've filed an issue upstream.