Bug 255116 - irc/irssi: Update to 1.2.3
Summary: irc/irssi: Update to 1.2.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lewis Cook
URL: https://irssi.org/NEWS/#v1-2-3
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-16 11:03 UTC by David O'Rourke
Modified: 2021-04-16 17:29 UTC (History)
1 user (show)

See Also:


Attachments
irc/irssi: Update to 1.2.3 (9.40 KB, patch)
2021-04-16 11:03 UTC, David O'Rourke
dor.bsd: maintainer-approval+
Details | Diff
irc/irssi: Update to 1.2.3 (9.48 KB, patch)
2021-04-16 13:22 UTC, David O'Rourke
dor.bsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David O'Rourke 2021-04-16 11:03:37 UTC
Created attachment 224158 [details]
irc/irssi: Update to 1.2.3

This patch updates irc/irssi to 1.2.3, which includes multiple bugfixes since the 1.2.2 release.

A full changelog is available at: https://irssi.org/NEWS/#v1-2-3

irc/irssi 1.2.2 included cherry-picked patches for some of these issues, these have been removed as upstream now includes the fixes.

-David
Comment 1 Lewis Cook freebsd_committer freebsd_triage 2021-04-16 11:19:06 UTC
Moin moin,

Do we strictly need be setting PORTREVISION here? Looking at prior versions, PORTEPOCH is enough.

$ pkg version -t pkg version -t 1.2.3,2 1.3.d.344_1,1
>
Comment 2 Lewis Cook freebsd_committer freebsd_triage 2021-04-16 11:19:56 UTC
(In reply to Lewis Cook from comment #1)
Mind the duplicated command, my copy-paste-foo failed me here. :)
Comment 3 David O'Rourke 2021-04-16 13:19:13 UTC
You're right, sorry. I should have removed the `PORTREVISION`, I forgot.
Updating diff incoming.

-David
Comment 4 David O'Rourke 2021-04-16 13:22:10 UTC
Created attachment 224163 [details]
irc/irssi: Update to 1.2.3

Updated diff removing the `PORTREVISION`.
Comment 5 commit-hook freebsd_committer 2021-04-16 17:28:42 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1ed838f5dead7db6ce68317480917f89461d848e

commit 1ed838f5dead7db6ce68317480917f89461d848e
Author:     Lewis Cook <lcook@FreeBSD.org>
AuthorDate: 2021-04-16 17:26:24 +0000
Commit:     Lewis Cook <lcook@FreeBSD.org>
CommitDate: 2021-04-16 17:28:17 +0000

    irc/irssi: Update to 1.2.3

    Changes:        https://irssi.org/NEWS/#v1-2-3
    PR:             255116
    Submitted by:   David O'Rourke <dor.bsd@xm0.uk> (maintainer)
    Approved by:    mentors (implicit)

 irc/irssi/Makefile                                 |  3 +-
 irc/irssi/distinfo                                 |  6 +-
 irc/irssi/files/patch-src_core_modules.c (gone)    | 20 ------
 .../patch-src_core_servers-reconnect.c (gone)      | 61 ------------------
 .../files/patch-src_core_servers-setup.c (gone)    | 72 ----------------------
 .../files/patch-src_fe-text_term-terminfo.c (gone) | 15 -----
 irc/irssi/pkg-plist                                |  1 +
 7 files changed, 5 insertions(+), 173 deletions(-)
Comment 6 Lewis Cook freebsd_committer freebsd_triage 2021-04-16 17:29:48 UTC
Committed, thanks!