Created attachment 224193 [details]
(In reply to Li-Wen Hsu from comment #0)
Regarding the change in line 729 of the patch
(here: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=224193&action=diff#b/ports-mgmt/portlint/src/portlint.pl_sec2 )
I haven't run it yet, but it looks like all @comments will be FATAL.
I think it's bad if it's not
&perror("FATAL", $file, $., "\$$rcsidstr\$ is deprecated in Git.") if (/\$$rcsidstr[:\$]/);
$rcsidseen doesn't even look like it's being used for anything anymore.
(In reply to Tatsuki Makino from comment #1)
Thanks for the review, TBH I only did the minimum tests and I don't think I fully understand the entire code base.
I'll try to squeeze some time on fixing this. If it's possible for you, please help updating this patch. Thanks!
Thanks for the patch. I'm working on this now.
A commit in branch main references this bug:
Author: Joe Marcus Clarke <marcus@FreeBSD.org>
AuthorDate: 2021-04-19 20:49:33 +0000
Commit: Joe Marcus Clarke <marcus@FreeBSD.org>
CommitDate: 2021-04-19 20:49:33 +0000
ports-mgmt/portlint: Update to 2.19.5
* Reverse $FreeBSD$ check logic to make the use of them FATAL 
* Remove embedded $FreeBSD$
PR: 255153 
Obtained from: lwhsu 
With issue report from Tatsuki Makino
ports-mgmt/portlint/Makefile | 2 +-
ports-mgmt/portlint/src/portlint.1 | 2 +-
ports-mgmt/portlint/src/portlint.pl | 49 +++++++++----------------------------
3 files changed, 13 insertions(+), 40 deletions(-)