Bug 255305 - graphics/tiff: Update to 4.3.0, switch to CMake
Summary: graphics/tiff: Update to 4.3.0, switch to CMake
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL: http://www.simplesystems.org/libtiff/...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-21 15:22 UTC by Daniel Engberg
Modified: 2021-04-23 21:13 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (portmgr)

Attachments
Patch for tiff (27.67 KB, patch)
2021-04-21 15:22 UTC, Daniel Engberg 		no flags Details | Diff
Patch for tiff v2 (36.43 KB, patch)
2021-04-21 17:42 UTC, Daniel Engberg 		no flags Details | Diff
Patch for tiff v3 (27.84 KB, patch)
2021-04-21 18:09 UTC, Daniel Engberg 		no flags Details | Diff
Patch for tiff v4 (27.47 KB, patch)
2021-04-21 18:21 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2021-04-21 15:22:27 UTC 
Created attachment 224332 [details]
Patch for tiff

Update to 4.3.0
Switch to CMake

Compile and run tested on FreeBSD 13.0-RC1 (aarch64) (make, make check-plist, make test)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2021-04-21 15:24:42 UTC 
Enable lzma(2) and zstd support to align us to other distributions such as Arch Linux, Alpine, Debian, Gentoo, OpenSUSE etc.
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2021-04-21 15:31:00 UTC 
MANPAGES should not be an option, it should be always on
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2021-04-21 15:41:18 UTC 
Also, the man page links are no longer created
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2021-04-21 15:47:51 UTC 
Sure, I can add that to defaults however I don't see why it shouldn't be optional. We have a lot of ports where it's optional and it's also been in Mk/bsd.options.desc.mk since 2012

I tried to track down the MLNKS thing, I can't find any other distro doing something similar and looking at the commit history I didn't find any obvious reason to it.
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2021-04-21 16:05:49 UTC 
(In reply to daniel.engberg.lists from comment #4)
The MANPAGES option is only when it needs exotic build dependencies.

For the links,  it's so that the man pages are usable.  Otherwise,  "man TIFFmalloc" etc will not work.
Comment 6 Tobias C. Berner freebsd_committer freebsd_triage 2021-04-21 16:10:26 UTC 
Moin moin

CMAKE_ARGS= -DCMAKE_DISABLE_FIND_PACKAGE_OpenGL:BOOL=True

could be

CMAKE_ON=CMAKE_DISABLE_FIND_PACKAGE_OpenGL

mfg Tobias
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2021-04-21 17:42:40 UTC 
Created attachment 224336 [details]
Patch for tiff v2

Use CMAKE_ON instead of CMAKE_ARGS
Enable manpages by default
Add back symlinks for manpages
Comment 8 Antoine Brodin freebsd_committer freebsd_triage 2021-04-21 17:45:47 UTC 
MANPAGES should not be an option
Comment 9 Daniel Engberg freebsd_committer freebsd_triage 2021-04-21 18:09:28 UTC 
Created attachment 224337 [details]
Patch for tiff v3

Always install manpages
Comment 10 Antoine Brodin freebsd_committer freebsd_triage 2021-04-21 18:13:41 UTC 
tiffgt.1.gz has to be removed to avoid conflict with graphics/tiffgt
Comment 11 Daniel Engberg freebsd_committer freebsd_triage 2021-04-21 18:21:43 UTC 
Created attachment 224338 [details]
Patch for tiff v4

Remove tiffgt.1 man page
Comment 12 Antoine Brodin freebsd_committer freebsd_triage 2021-04-23 21:13:30 UTC 
I will commit my own version of the update that keeps using gnu configure.

The CMake version is buggy  (broken pkgconfig file, removed static lib that is needed by some ports etc.)