Bug 255672 - ports-mgmt/distilator: Prints warnings with python-38
Summary: ports-mgmt/distilator: Prints warnings with python-38
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-06 22:10 UTC by Yuri Victorovich
Modified: 2021-05-07 06:33 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2021-05-06 22:10:25 UTC
distilator-1.3 prints this:
> $ distilator 
> /usr/local/bin/distilator:41: SyntaxWarning: "is not" with a literal. Did you mean "!="?
>   if thisurl.scheme is not "":
> /usr/local/bin/distilator:132: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   if urlparse(url).scheme is "http" or "https":
> /usr/local/bin/distilator:163: SyntaxWarning: "is" with a literal. Did you mean "=="?
>   if urlparse(url).scheme is "ftp":
Comment 1 commit-hook freebsd_committer 2021-05-07 06:32:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3a978f1c8a56703f903ba1101cbeac47dcd84382

commit 3a978f1c8a56703f903ba1101cbeac47dcd84382
Author:     Emanuel Haupt <ehaupt@FreeBSD.org>
AuthorDate: 2021-05-07 06:29:51 +0000
Commit:     Emanuel Haupt <ehaupt@FreeBSD.org>
CommitDate: 2021-05-07 06:29:51 +0000

    ports-mgmt/distilator: Fix warnings emitted by python 3.8

    PR:             255672
    Reported by:    yuri

 ports-mgmt/distilator/Makefile                     |  1 +
 .../distilator/files/patch-distilator.py (new)     | 38 ++++++++++++++++++++++
 2 files changed, 39 insertions(+)
Comment 2 Emanuel Haupt freebsd_committer 2021-05-07 06:33:41 UTC
Fixed, thanks!