Bug 255707 - devel/glib20: update alternate FAM backend
Summary: devel/glib20: update alternate FAM backend
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-08 13:38 UTC by Ivan Rozhuk
Modified: 2022-07-19 00:13 UTC (History)
9 users (show)

See Also:
fluffy: maintainer-feedback+


Attachments
patch (6.88 KB, patch)
2021-05-08 13:38 UTC, Ivan Rozhuk
rozhuk.im: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2021-05-08 13:38:23 UTC
Created attachment 224772 [details]
patch

Multiple changes:
- Add support O_PATH flag for open()
- Use O_DIRECTORY for dir open
- close() fd on kevent() fail for files
- Fix possible memleak in kq_handle_rename(): 32kb per call
- Move fstat() from kq_handle_rename() to readdir_start()
- Do not try to monitor for: DT_FIFO, DT_SOCK, DT_WHT
Comment 1 Ivan Rozhuk 2021-07-02 02:23:26 UTC
ping
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2022-02-02 20:04:58 UTC
Could this very useful patch be committed, please?

See also:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254024
Comment 3 Tomoaki AOKI 2022-05-01 23:31:43 UTC
(In reply to Emanuel Haupt from comment #2)

+1.
This patch singificantly reduce wasted time on file dialog of gtk3.
Of course With OPTIONS_FILE_SET+=FAM_ALTBACKEND.

Now gtk3 softwares can open file dialog almost as fast as gtk2 softwares.
Thanks, Ivan!