Bug 255983 - New port: net/ipinfo-cli: Official Command Line Interface for the IPinfo API
Summary: New port: net/ipinfo-cli: Official Command Line Interface for the IPinfo API
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guangyuan Yang
URL: https://github.com/ipinfo/cli
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-19 00:20 UTC by Gabriel Dutra
Modified: 2021-06-08 00:20 UTC (History)
2 users (show)

See Also:


Attachments
ipinfo-cli (3.60 KB, application/shar)
2021-05-19 00:20 UTC, Gabriel Dutra
0xdutra: maintainer-approval+
Details
Fix (3.58 KB, patch)
2021-05-25 01:14 UTC, Gabriel Dutra
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Dutra 2021-05-19 00:20:27 UTC
Created attachment 225077 [details]
ipinfo-cli

Tested on

FreeBSD: 14-amd64 14-i386 13-amd64 13-i386 12-amd64 12-i386 11-amd64 11-i386

Portlint: no errors
Comment 1 Daniel Engberg 2021-05-22 23:53:00 UTC
Quick review on a few things can be tweaked

PORTVERSION --> DISTVERSION
DISTVERSIONPREFIX should be defined before DISTVERSION
You don't need to define GH_ACCOUNT see
https://docs.freebsd.org/en/books/porters-handbook/book.html#makefile-master_sites-github-description
Comment 2 Gabriel Dutra 2021-05-25 01:14:51 UTC
Created attachment 225240 [details]
Fix

Hi Daniel!

I applied your suggestions, please consider a new review.
Comment 3 Guangyuan Yang freebsd_committer 2021-06-08 00:20:17 UTC
(In reply to Gabriel Dutra from comment #2)

The patch looks good to me - the only thing I'd suggest is to have a more enriched pkg-descr than the current one. It should be a couple of full sentences explaining what it is and what its main functionalities are, instead of just duplicating COMMENTS=.

Once this is updated, I can proceed to commit this port. Thanks!