Bug 256160 - editors/with-editor: Update to 3.0.4.
Summary: editors/with-editor: Update to 3.0.4.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/magit/with-editor/...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-25 20:24 UTC by Yasuhiro Kimura
Modified: 2021-05-26 11:38 UTC (History)
1 user (show)

See Also:


Attachments
Patch file (1.35 KB, patch)
2021-05-25 20:24 UTC, Yasuhiro Kimura
yasu: maintainer-approval+
Details | Diff
Updated patch file (2.17 KB, patch)
2021-05-26 10:27 UTC, Yasuhiro Kimura
yasu: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer 2021-05-25 20:24:34 UTC
Created attachment 225264 [details]
Patch file

Update to 3.0.4.

Changes: https://github.com/magit/with-editor/commits/v3.0.4
Comment 1 Nuno Teixeira freebsd_committer 2021-05-26 06:29:28 UTC
Hello!

portclippy Makefile shows a better block order:
---
# PORTNAME block
PORTNAME
DISTVERSIONPREFIX
DISTVERSION
PORTREVISION
CATEGORIES
PKGNAMESUFFIX

# Maintainer block
MAINTAINER
COMMENT

# License block
LICENSE
LICENSE_FILE

# USES block
USEShat?
USE_GITHUB
GH_ACCOUNT

# Make block
+MAKE_ENV

# Standard bsd.port.mk variables
NO_ARCH

# Packaging list block
INFO

-MAKE_ENV

PLIST_FILES
+PORTDOCS

# Options definitions
OPTIONS_DEFINE

-PORTDOCS
---

Could you please check that?
Comment 2 Yasuhiro Kimura freebsd_committer 2021-05-26 10:27:42 UTC
Created attachment 225271 [details]
Updated patch file

(In reply to Nuno Teixeira from comment #1)

* Pet portclippy.
* Reformat with portfmt.
Comment 3 commit-hook freebsd_committer 2021-05-26 11:35:34 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=68c6c90da614dd1f30dc3fa32b7a4d4518b839b4

commit 68c6c90da614dd1f30dc3fa32b7a4d4518b839b4
Author:     Yasuhiro Kimura <yasu@utahime.org>
AuthorDate: 2021-05-26 11:29:05 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2021-05-26 11:34:03 +0000

    editors/with-editor: Update to 3.0.4.

    - Pet portclippy.
    - Reformat with portfmt.

    ChangeLog: https://github.com/magit/with-editor/commits/v3.0.4

    PR:             256160
    Approved by:    dbaio, garga (mentors, implicit)

 editors/with-editor/Makefile | 17 ++++++++---------
 editors/with-editor/distinfo |  6 +++---
 2 files changed, 11 insertions(+), 12 deletions(-)
Comment 4 Nuno Teixeira freebsd_committer 2021-05-26 11:38:24 UTC
Commited thanks!