Bug 256210 - cad/digital: extract icon into /usr/local/share/pixmaps, use more common category
Summary: cad/digital: extract icon into /usr/local/share/pixmaps, use more common cate...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-28 00:42 UTC by Duane
Modified: 2021-05-28 01:37 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Duane 2021-05-28 00:42:30 UTC
When this program renders in the application menu it doesn't have an icon, and additionally it appears in the "Other" category (when using icewm).

I propose extracting the icons/icon48.png file from the jar and putting it in /usr/local/share/pixmaps/digital.png, and then updating the digital.desktop file to have the line:

Icon=digital

I would also suggest adding the Education and/or Science to the categories as well so that it falls into one of the more common existing categories.
Comment 1 Duane 2021-05-28 00:46:18 UTC
Sorry, regarding the Category I just found the relevant specifications at https://specifications.freedesktop.org/menu-spec/menu-spec-1.0.html#category-registry which states "Note that at least one Main Category must be included in the desktop entry's list of categories"

I would then propose that either Education or Development be chosen as the applications Main Category.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2021-05-28 01:37:42 UTC
Fix committed. Thanks for noticing this problem!

Icon files now appear to be installed properly but on XFCE4 they don't work for some reason. Possibly due to some bug.

Please let me know if icon works for you in your environment.
Comment 3 commit-hook freebsd_committer freebsd_triage 2021-05-28 01:37:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=eabb1532ca37317952fd79ee8ce3fa91108882eb

commit eabb1532ca37317952fd79ee8ce3fa91108882eb
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2021-05-28 01:33:26 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2021-05-28 01:37:40 +0000

    cad/digital: Install icons and desktop file provided by the project

    PR:             256210
    Reported by:    Duane <parakleta@darkreality.org>

 cad/digital/Makefile | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)