Bug 256230 - security/oidentd 2.5.1 released with FreeBSD 13+ fix
Summary: security/oidentd 2.5.1 released with FreeBSD 13+ fix
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Oliver Lehmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-28 23:56 UTC by Bryan Drewery
Modified: 2021-06-15 14:10 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (oliver)


Attachments
Patch for oidentd (1.55 KB, patch)
2021-05-31 19:20 UTC, Daniel Engberg
no flags Details | Diff
oidentd.conf.sample (214 bytes, patch)
2021-06-15 14:10 UTC, David M.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bryan Drewery freebsd_committer 2021-05-28 23:56:42 UTC
https://github.com/janikrabe/oidentd/commit/cd763e5aebc7f84fff0acad792d3e2a9b0ecdccb

> FreeBSD 5 introduced the `xucred` struct for external users in commit
> c0511d3b58c985e17c0c23585ea7d16b6f52fe61 to avoid breaking user space
> applications when the `ucred` struct changes.
> 
> oidentd happened to still work after this commit because the EUID it
> reads was stored at the same location in both structures. This is no
> longer the case with FreeBSD 13.
> 
> This commit updates the freebsd5 module to use `xucred` instead of
> `ucred` as the expected return type for getcred calls.

This is the extent of 2.5.0 -> 2.5.1 so the whole release can come in.

A trivial s/2.5.0/2.5.1/ in the Makefile seems enough for me.
Comment 1 Daniel Engberg 2021-05-31 19:20:36 UTC
Created attachment 225425 [details]
Patch for oidentd

Modify Makefile to follow Porter's Handbook more closely
Define LICENSE_FILE
Switch to tar.xz release archive
Remove IPV6 option (it's 2021 not 1999)

Compile tested on FreeBSD 13.0-STABLE n245227-5ec4eb443e8 (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 11.4-RELEASE (amd64)
Comment 2 Daniel Engberg 2021-06-15 07:26:52 UTC
Bryan,

Maintainer timeout, something you can have a look at?

Regards,
Daniel
Comment 3 David M. 2021-06-15 14:10:37 UTC
Created attachment 225828 [details]
oidentd.conf.sample

Updated default configuration file to hide root connections.