Bug 256360 - New port comms/rtl-433 name is typoed
Summary: New port comms/rtl-433 name is typoed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-01 23:43 UTC by ports-rtl433
Modified: 2021-06-21 20:34 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ports-rtl433 2021-06-01 23:43:17 UTC
A new port, comms/rtl-433 was created two days ago.  Unfortunately, the name of the directory is typoed as "rtl-443", rather than "rtl-433".

    grep PORTNAME /usr/ports/comms/rtl-443/Makefile
    PORTNAME=       rtl-433

Please rename.


As an aside, this seems like something that maybe portlint should catch?  Unless MASTERDIR is defined, PORTNAME and $PWD should match, or something like that?

Thanks.
Comment 1 Li-Wen Hsu freebsd_committer 2021-06-02 02:21:15 UTC
Over to the maintainer/committer.
Comment 2 Rodrigo Osorio freebsd_committer 2021-06-21 07:51:34 UTC
(In reply to ports-rtl433 from comment #0)
Thanks for reporting. I will fix my typo ASAP.

Regarding the check, if most of the ports name matches the dirname,
this is not a mandatory rule and does not match many ports, a quick
calculation gives me 16154 ports):

...snap...
/usr/ports/archivers/erlang-snappy => snappy
/usr/ports/archivers/fpc-bzip2 =>
/usr/ports/archivers/gtar => tar
/usr/ports/archivers/ocaml-bz2 => bz2
/usr/ports/archivers/opkg-openwrt => opkg
/usr/ports/archivers/lha-ac => lha
...snap...
Comment 3 commit-hook freebsd_committer 2021-06-21 20:33:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e259367c29da41ce739a5fe76d834519f4d75b9d

commit e259367c29da41ce739a5fe76d834519f4d75b9d
Author:     Rodrigo Osorio <rodrigo@FreeBSD.org>
AuthorDate: 2021-06-21 20:27:14 +0000
Commit:     Rodrigo Osorio <rodrigo@FreeBSD.org>
CommitDate: 2021-06-21 20:27:14 +0000

    comms/rtl-433: Fix typo in ports directory name

    PR:             256360
    Reported by:    ports-rtl433@shalott.net

 MOVED                                | 1 +
 comms/Makefile                       | 2 +-
 comms/{rtl-443 => rtl-433}/Makefile  | 0
 comms/{rtl-443 => rtl-433}/distinfo  | 0
 comms/{rtl-443 => rtl-433}/pkg-descr | 0
 comms/{rtl-443 => rtl-433}/pkg-plist | 0
 6 files changed, 2 insertions(+), 1 deletion(-)