Bug 256495 - benchmarks/iperf3: Make static library optional and disable it by default
Summary: benchmarks/iperf3: Make static library optional and disable it by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bruce A. Mah
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-09 07:55 UTC by Daniel Engberg
Modified: 2021-06-11 15:23 UTC (History)
0 users

See Also:
bmah: maintainer-feedback+


Attachments
Patch for iperf3 (1.31 KB, patch)
2021-06-09 07:55 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg 2021-06-09 07:55:52 UTC
Created attachment 225656 [details]
Patch for iperf3

Follow other ports (also distros) and make static library optional (disabled by default). While at it, do some minor changes in Makefile to make to follow Porter's Handbook more closely.

Compile tested on 13.0-STABLE #0 stable/13-n245283-70a2e9a3d44 (arm64) (make, make check-plist)
Comment 1 Bruce A. Mah freebsd_committer 2021-06-11 14:57:21 UTC
Thanks for the patch, looks good!  Doing a little testing on it, so far so good...
Comment 2 commit-hook freebsd_committer 2021-06-11 15:08:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6f86d9470517968d72b71a829e1c6fe4e6192773

commit 6f86d9470517968d72b71a829e1c6fe4e6192773
Author:     Daniel Engberg <daniel.engberg.lists@pyret.net>
AuthorDate: 2021-06-11 15:03:43 +0000
Commit:     Bruce A. Mah <bmah@FreeBSD.org>
CommitDate: 2021-06-11 15:06:14 +0000

    benchmarks/iperf3: Make static library optional.

    While here, do some minor changes to Makefile to follow the Porter's
    Handbook more closely.

    PR:             256495

 benchmarks/iperf3/Makefile  | 10 +++++++---
 benchmarks/iperf3/pkg-plist |  2 +-
 2 files changed, 8 insertions(+), 4 deletions(-)
Comment 3 Bruce A. Mah freebsd_committer 2021-06-11 15:09:13 UTC
Done, assuming I didn't somehow mess up a git / Bugzilla workflow that I only do maybe once a year. Thanks!
Comment 4 Daniel Engberg 2021-06-11 15:23:02 UTC
Commit looks good, Thanks!