Bug 256629 - x11-toolkits/tk87: Add build dependency on archivers/zip
Summary: x11-toolkits/tk87: Add build dependency on archivers/zip
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pietro Cerutti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-06-15 20:15 UTC by m.ne
Modified: 2021-06-16 09:15 UTC (History)
3 users (show)

See Also:


Attachments
Patch adding build dependency on archivers/zip (427 bytes, patch)
2021-06-15 20:15 UTC, m.ne
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description m.ne 2021-06-15 20:15:37 UTC
Created attachment 225836 [details]
Patch adding build dependency on archivers/zip

My build of tk87 failed with a reference to missing zip. A build dependency on archivers/zip worked for me.

The relevant sections from the build log:

checking whether char is unsigned... no
checking for macher... checking for zip... No zip found on PATH. Building minizip
checking for building with zipfs... yes
configure: creating ./config.status
config.status: creating Makefile
config.status: creating tkConfig.sh
config.status: creating tk.pc
configure: WARNING: unrecognized options: --enable-threads, --with-tclinclude
===========================================================================
=======================<phase: build          >============================

<<snip>>

cc -c -I/wrkdirs/usr/ports/x11-toolkits/tk87/work/tk8.7a5/unix/../unix -I/wrkdirs/usr/ports/x11-toolkits/tk87/work/tk8.7a5/unix/../generic -I/wrkdirs/usr/ports/x11-toolkits/tk87/work/tk8.7a5/unix/../bitmaps  -I/usr/local/include -O2 -O2 -pipe  -I/usr/local/include/tcl8.7 -I/usr/local/include -fstack-protector-strong -fno-strict-aliasing  -pipe  -finput-charset=UTF-8 -Wall -Wextra -Wshadow -Wundef -Wwrite-strings -Wpointer-arith -Wc++-compat -fextended-identifiers  -fPIC -DBUILD_tk -I/usr/local/include/tcl8.7/generic -I/usr/local/include/tcl8.7/unix -DPACKAGE_NAME=\"tk\" -DPACKAGE_TARNAME=\"tk\" -DPACKAGE_VERSION=\"8.7\" -DPACKAGE_STRING=\"tk\ 8.7\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DTCL_CFGVAL_ENCODING=\"utf-8\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_TIME_H=1 -DSTDC_HEADERS=1 -DMODULE_SCOPE=extern\ __attribute__\(\(__visibility__\(\"hidden\"\)\)\) -DHAVE_HIDDEN=1 -DHAVE_CAST_TO_UNION=1 -DHAVE_STDBOOL_H=1 -DTCL_SHLIB_EXT=\".so\" -DNDEBUG=1 -DTCL_CFG_OPTIMIZED=1 -DTCL_WIDE_INT_IS_LONG=1 -DHAVE_INTPTR_T=1 -DHAVE_UINTPTR_T=1 -DHAVE_PW_GECOS=1 -DHAVE_LIBXFT=1 -DHAVE_XFT=1 -DHAVE_XSS=1 -DZIPFS_BUILD=1       -DTCL_NO_DEPRECATED -DUSE_TCL_STUBS /wrkdirs/usr/ports/x11-toolkits/tk87/work/tk8.7a5/unix/../unix/tkUnixXId.c
make[1]: don't know how to make minizip. Stop

make[1]: stopped in /wrkdirs/usr/ports/x11-toolkits/tk87/work/tk8.7a5/unix
*** Error code 1

Stop.
make: stopped in /usr/ports/x11-toolkits/tk87
Comment 1 Alexey Dokuchaev freebsd_committer 2021-06-16 04:42:55 UTC
Over to de facto Tcl/Tk maintainer.
Comment 2 commit-hook freebsd_committer 2021-06-16 09:11:40 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3bebcafdc346d1f0114a98a1f6afc66fcedff6ad

commit 3bebcafdc346d1f0114a98a1f6afc66fcedff6ad
Author:     Pietro Cerutti <gahr@FreeBSD.org>
AuthorDate: 2021-06-16 09:00:53 +0000
Commit:     Pietro Cerutti <gahr@FreeBSD.org>
CommitDate: 2021-06-16 09:10:39 +0000

    x11-toolkits/tk87: add build dependency on zip

    PR:             256629
    Reported by:    m.ne@gmx.net

 x11-toolkits/tk87/Makefile | 1 +
 1 file changed, 1 insertion(+)