Bug 256639 - net/wireguard-kmod doesn't build on the most recent stable/13
Summary: net/wireguard-kmod doesn't build on the most recent stable/13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Bernhard Froehlich
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2021-06-16 08:32 UTC by Marek Zarychta
Modified: 2021-06-16 20:21 UTC (History)
3 users (show)

See Also:
linimon: maintainer-feedback? (decke)


Attachments
build log file (9.55 KB, text/plain)
2021-06-16 08:32 UTC, Marek Zarychta
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Zarychta 2021-06-16 08:32:25 UTC
Created attachment 225849 [details]
build log file

The most recent version wireguard-kmod-0.0.20210606 fails to build on table/13 with "error: static declaration of 'taskqgroup_drain_all' follows non-static declaration". More details in attached log file.
Comment 1 Herbert J. Skuhra 2021-06-16 11:36:05 UTC
This is already fixed in git:

https://git.zx2c4.com/wireguard-freebsd/commit/?id=64a507ad6b3c7e8455c67b452160b9e4211fd872
Comment 2 Marek Zarychta 2021-06-16 13:32:10 UTC
(In reply to Herbert J. Skuhra from comment #1)
Thank you for reporting it upstream and for the clue. I have patched it solves the issue.
Comment 3 commit-hook freebsd_committer 2021-06-16 18:41:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=57eb088f783473d1a7975d31a669d50b2f724e42

commit 57eb088f783473d1a7975d31a669d50b2f724e42
Author:     Bernhard Froehlich <decke@FreeBSD.org>
AuthorDate: 2021-06-16 18:28:48 +0000
Commit:     Bernhard Froehlich <decke@FreeBSD.org>
CommitDate: 2021-06-16 18:40:01 +0000

    net/wireguard-kmod: Fix build on latest stable/13

    PR:             256639
    Obtained from:  https://git.zx2c4.com/wireguard-freebsd/commit/?id=64a507ad6b3c7e8455c67b452160b9e4211fd872

 net/wireguard-kmod/Makefile                   |  1 +
 net/wireguard-kmod/files/patch-compat.h (new) | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)
Comment 4 commit-hook freebsd_committer 2021-06-16 18:45:31 UTC
A commit in branch 2021Q2 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0e355ccdc9cf44ab92353a08efd3e8b323886937

commit 0e355ccdc9cf44ab92353a08efd3e8b323886937
Author:     Bernhard Froehlich <decke@FreeBSD.org>
AuthorDate: 2021-06-16 18:28:48 +0000
Commit:     Bernhard Froehlich <decke@FreeBSD.org>
CommitDate: 2021-06-16 18:43:48 +0000

    net/wireguard-kmod: Fix build on latest stable/13

    PR:             256639
    Obtained from:  https://git.zx2c4.com/wireguard-freebsd/commit/?id=64a507ad6b3c7e8455c67b452160b9e4211fd872

    (cherry picked from commit 57eb088f783473d1a7975d31a669d50b2f724e42)

 net/wireguard-kmod/Makefile                   |  1 +
 net/wireguard-kmod/files/patch-compat.h (new) | 22 ++++++++++++++++++++++
 2 files changed, 23 insertions(+)
Comment 5 Bernhard Froehlich freebsd_committer 2021-06-16 18:47:34 UTC
Sorry, was a busy week and I did not have time to do it before. Should be fine now.
Comment 6 Marek Zarychta 2021-06-16 20:21:14 UTC
(In reply to Bernhard Froehlich from comment #5)
Thank you for solving this in an expedited way.