Bug 256818 - multimedia/vdr-plugin-xineliboutput: fix build
Summary: multimedia/vdr-plugin-xineliboutput: fix build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yasuhiro Kimura
URL: https://sourceforge.net/p/xineliboutp...
Keywords: needs-qa, regression
Depends on:
Blocks:
 
Reported: 2021-06-24 22:28 UTC by Stefan Ehmann
Modified: 2021-10-31 11:44 UTC (History)
2 users (show)

See Also:
koobs: merge-quarterly?


Attachments
patch to fix build (2.33 KB, patch)
2021-06-24 22:28 UTC, Stefan Ehmann
no flags Details | Diff
patch-configure (6.68 KB, patch)
2021-08-31 07:06 UTC, Stefan Rumetshofer
no flags Details | Diff
patch-c++11 (7.88 KB, patch)
2021-08-31 07:07 UTC, Stefan Rumetshofer
no flags Details | Diff
vdr-plugin-xineliboutput.diff (11.15 KB, patch)
2021-08-31 07:35 UTC, Stefan Rumetshofer
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Ehmann 2021-06-24 22:28:59 UTC
Created attachment 226043 [details]
patch to fix build

After recent changes (probably libglvnd related) the port fails to build with:
ld: error: undefined symbol: glXQueryVersion

I've created a patch to include the upstream fix
https://sourceforge.net/p/xineliboutput/git/ci/7409b309432f21d871b9c37600e9c3c0632628ab/

See PR 253304 for discussion on the state of vdr* ports. I still don't have time to do a proper update.
Comment 1 Stefan Rumetshofer 2021-08-31 07:06:59 UTC
Created attachment 227565 [details]
patch-configure
Comment 2 Stefan Rumetshofer 2021-08-31 07:07:36 UTC
Created attachment 227566 [details]
patch-c++11
Comment 3 Stefan Rumetshofer 2021-08-31 07:09:47 UTC
I put your patch and the existing one for the configure script together.
And i also created a patch which unbreaks the build with c++11.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2021-08-31 07:14:58 UTC
Thank you for the report and patch Stefan. 

If you can manage and have time, a single patch against the port would be great. 

Patches/changes against upstream sources can be produced automatically using the 'make makepatch' target in the port dir, after creating $file $file.orig pairs and making the changes in $file
Comment 5 Stefan Rumetshofer 2021-08-31 07:35:52 UTC
Created attachment 227567 [details]
vdr-plugin-xineliboutput.diff

Here is the diff against the whole port
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2021-09-01 00:56:53 UTC
(In reply to Stefan Rumetshofer from comment #5)

Thanks Stefan!
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2021-09-01 00:57:58 UTC
Comment on attachment 227567 [details]
vdr-plugin-xineliboutput.diff

Approved by: portmgr (blanket: unmaintained port)
MFH: Yes
Comment 8 Yasuhiro Kimura freebsd_committer freebsd_triage 2021-10-31 11:36:41 UTC
Take.
Comment 9 commit-hook freebsd_committer freebsd_triage 2021-10-31 11:39:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2da8e962e30a8dd2f5caa825036cfec2ee867a7d

commit 2da8e962e30a8dd2f5caa825036cfec2ee867a7d
Author:     Stefan Ehmann <shoesoft@gmx.net>
AuthorDate: 2021-10-31 11:03:43 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2021-10-31 11:38:19 +0000

    multimedia/vdr-plugin-xineliboutput: Fix build

    * Add NLS option
    * Pet portclippy
    * Re-fromat Makefile with portfmt

    PR:             256818
    Approved by:    portmgr (blanket: unmaintained port)
    MFH:            2021Q4

 multimedia/vdr-plugin-xineliboutput/Makefile       |  41 +++---
 .../files/patch-c++11 (new)                        | 163 +++++++++++++++++++++
 .../vdr-plugin-xineliboutput/files/patch-configure |  28 +++-
 3 files changed, 208 insertions(+), 24 deletions(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2021-10-31 11:41:19 UTC
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0241af1ae392e8eda6f6d9566b91ac5f55bc3d83

commit 0241af1ae392e8eda6f6d9566b91ac5f55bc3d83
Author:     Stefan Ehmann <shoesoft@gmx.net>
AuthorDate: 2021-10-31 11:03:43 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2021-10-31 11:40:36 +0000

    multimedia/vdr-plugin-xineliboutput: Fix build

    * Add NLS option
    * Pet portclippy
    * Re-fromat Makefile with portfmt

    PR:             256818
    Approved by:    portmgr (blanket: unmaintained port)
    MFH:            2021Q4

    (cherry picked from commit 2da8e962e30a8dd2f5caa825036cfec2ee867a7d)

 multimedia/vdr-plugin-xineliboutput/Makefile       |  41 +++---
 .../files/patch-c++11 (new)                        | 163 +++++++++++++++++++++
 .../vdr-plugin-xineliboutput/files/patch-configure |  28 +++-
 3 files changed, 208 insertions(+), 24 deletions(-)
Comment 11 Yasuhiro Kimura freebsd_committer freebsd_triage 2021-10-31 11:44:09 UTC
Committed and merged to quarterly branch. Thanks!