Bug 256932 - x11-fonts/charis: Failed for devilutionX-1.2.1 in build-depends
Summary: x11-fonts/charis: Failed for devilutionX-1.2.1 in build-depends
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-02 06:51 UTC by Nuno Teixeira
Modified: 2021-07-02 21:31 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nuno Teixeira freebsd_committer 2021-07-02 06:51:33 UTC
Hello Thiery!

charis 6.000 breaks dependency build of devilutionX.

Extracting CharisSIL-6.000: .......... done

===>   devilutionX-1.2.1 depends on file: /usr/local/share/fonts/CharisSIL/CharisSIL-B.ttf - not found
*** Error code 1

I've noticed that font names have changed from 5.000:
> .for type in B BI I R
to 6.000:
> +.for type in Bold BoldItalic Italic Regular

 PLIST_FILES+=	${FONTSDIR}/${PORTNAME}-${type}.ttf

---

devilutionX are looking for CharisSIL-B.ttf and now it is called CharisSIL-Bold.ttf

What is the best way to solve this?

Cheers
Comment 1 Thierry Thomas freebsd_committer 2021-07-02 15:15:25 UTC
Fix committed, thanks for the report!
Comment 2 commit-hook freebsd_committer 2021-07-02 15:15:28 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ccb30d4faa30a69709e3959468e6838fb87b6709

commit ccb30d4faa30a69709e3959468e6838fb87b6709
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2021-07-02 14:15:00 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2021-07-02 14:15:00 +0000

    games/devilutionX: chase the upgrade of x11-fonts/charis

    PR:             256932
    Reported by:    eduardo@ (devilutionX’s maintainer)

 games/devilutionX/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 3 Nuno Teixeira freebsd_committer 2021-07-02 21:31:31 UTC
(In reply to Thierry Thomas from comment #1)

1. PORTREVISION=1
---
/!\ devilutionX-1: Makefile errors /!\

Defining both PORTVERSION and DISTVERSION is wrong, only set one, if necessary,
set DISTNAME

*** Error code 1
---

2. "_MY_DEPENDS=CharisSIL>0:x11-fonts/charis" looks nice

3. But keep in mind CXXFLAGS:

CXXFLAGS+=-DTTF_FONT_NAME=\\\"${LOCALBASE}/share/fonts/CharisSIL/CharisSIL-B.ttf\\\"

it needs to be changed to:

CXXFLAGS+=-DTTF_FONT_NAME=\\\"${LOCALBASE}/share/fonts/CharisSIL/CharisSIL-Bold.ttf\\\"

so that "Shows Credits" menu works otherwise it won't show sliding text appear.

I've pointed CXXFLAGS to CharisSIL-Bold.ttf and it works ok.