Bug 256988 - x11/xdg-desktop-portal-wlr: unbreak build with PipeWire 0.3.31
Summary: x11/xdg-desktop-portal-wlr: unbreak build with PipeWire 0.3.31
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jan Beich
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2021-07-05 10:14 UTC by Ghost
Modified: 2021-07-05 14:12 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (jbeich)
2khramtsov: maintainer-feedback?
2khramtsov: merge-quarterly?

Attachments
patch (2.35 KB, patch)
2021-07-05 10:14 UTC, Ghost 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ghost 2021-07-05 10:14:20 UTC 
Created attachment 226232 [details]
patch

poudriere testport on 14-CURRENT/amd64 with the current PipeWire in ports: OK.
(I know, will setup 11/12/13 aarch64/amd64 jails later)

For CI, if this is an option to you, you can consider adding __BSD_VISIBLE upstream until a PipeWire version with https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/91988acb6b6ad3d079a64e473a68abef7e1e3a18

Thanks for reporting this.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2021-07-05 13:52:12 UTC 
Defining __BSD_VISIBLE neutralizes standard compliance: ANSI, C99/C11, POSIX. It's an ugly hack better limited to specific files. Passing -D__BSD_VISIBLE globally is no different from conditionally disabling -D_POSIX_C_SOURCE=<...>
Comment 2 Ghost 2021-07-05 14:12:25 UTC 
(In reply to Jan Beich from comment #1)

OK, I agree. I guess you prefer to see this fixed in PipeWire.
This was build tested in 13/aarch64 both qemu-user-static and native (via #freebsd-ports by FUZxxl volunteered, I didn't ask), waited for other jails.

Closing this then, feel free to reopen.