Bug 257090 - [NEW PORT] misc/komorebi: Animated wallpaper manager
Summary: [NEW PORT] misc/komorebi: Animated wallpaper manager
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-07-09 23:24 UTC by Fadel
Modified: 2021-07-12 16:01 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (fjachuf)


Attachments
patch (6.28 KB, patch)
2021-07-09 23:24 UTC, Fadel
no flags Details | Diff
Komorebi (1.71 KB, patch)
2021-07-11 23:31 UTC, Fadel
no flags Details | Diff
Komorebi 1.1 (7.45 KB, patch)
2021-07-12 15:55 UTC, Fadel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fadel 2021-07-09 23:24:52 UTC
Created attachment 226335 [details]
patch

Animated wallpaper for your desktop like xfce, gnome, mate, etc.
Comment 1 Ka Ho Ng freebsd_committer 2021-07-09 23:38:41 UTC
My first glance without building it yet.

> +USE_GITHUB=	yes
> +GH_ACCOUNT=	SrWither
> +GH_PROJECT=	KomorebiBSD
> +GH_TAGNAME= 1.1
> +
>
> +MAINTAINER=	fjachuf@gmail.com
> +COMMENT=	Animated Wallpaper for your desktop
> +USES= cmake pkgconfig
Wrong section orders.

> +#PLIST_FILES=
Just drop it if it does not constitute any meaning.

You miss the dependencies of your port to be properly build and run as well.
Consider running portlint -abct to check the sanity of the files. Handbook link:
https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-portlint
Comment 2 Fadel 2021-07-11 23:31:28 UTC
Created attachment 226380 [details]
Komorebi
Comment 3 Fadel 2021-07-11 23:33:39 UTC
Comment on attachment 226380 [details]
Komorebi

Animated Wallpaper Manager
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-12 02:22:09 UTC
@Reporter Please provide a single patch will all changes included (second attachment missing pkg-plist). Confirmation of QA [1] passing would also be great

[1] poudriere and portlint at least: https://docs.freebsd.org/en/books/porters-handbook/testing/
Comment 5 Fadel 2021-07-12 15:55:11 UTC
Created attachment 226401 [details]
Komorebi 1.1
Comment 6 Fadel 2021-07-12 16:01:01 UTC
(In reply to Kubilay Kocak from comment #4)
I put the command make stage-qa to see what I got, this was the result

Out: 
❯ doas make stage-qa
Password:
====> Running Q/A tests (stage-qa)

komorebi git/master
❯