Bug 257321 - math/eigen3: Remove unnecessary OpenBLAS dependency
Summary: math/eigen3: Remove unnecessary OpenBLAS dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-kde (Team)
URL: https://eigen.tuxfamily.org/index.php...
Keywords: needs-patch, needs-qa
Depends on:
Blocks: 251842
  Show dependency treegraph
Reported: 2021-07-22 00:30 UTC by alt2600
Modified: 2021-09-08 11:06 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (kde)
koobs: merge-quarterly?

patch-eigen3-Makefile-Disable-Full (303 bytes, patch)
2021-07-22 17:00 UTC, alt2600
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description alt2600 2021-07-22 00:30:55 UTC


Eigen doesn't have any dependencies other than the C++ standard library.

We use the CMake build system, but only to build the documentation and unit-tests, and to automate installation. If you just want to use Eigen, you can use the header files right away. There is no binary library to link to, and no configured header file. Eigen is a pure template library defined in the headers. 

there is no reason why this has OpenBLAS as a required library. This should also close PR 251842, for the same basic reason. Nor would it seemingly need any of the other listed library dependencies

Library dependencies:

        libcholmod.so : math/suitesparse-cholmod
        libumfpack.so : math/suitesparse-umfpack
        libsuperlu.so : math/superlu
        libadolc.so : math/adol-c
        libfftw3.so : math/fftw3
        libmpfr.so : math/mpfr
        libgmp.so : math/gmp
        libboost_thread.so : devel/boost-libs
        libopenblas.so : math/openblas
Comment 1 alt2600 2021-07-22 17:00:22 UTC
Created attachment 226619 [details]

Patch attached. This simply turns off the FULL option as a Default

check-orphans confirms there is no change with "building" the port.

/usr/ports/math/eigen3|$} sudo make check-orphans
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
Comment 2 commit-hook freebsd_committer 2021-09-07 21:31:08 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b41385d1aad52bf5e2e6f2bb65777e201d9e5cd7

commit b41385d1aad52bf5e2e6f2bb65777e201d9e5cd7
Author:     Adriaan de Groot <adridg@FreeBSD.org>
AuthorDate: 2021-09-07 08:58:27 +0000
Commit:     Adriaan de Groot <adridg@FreeBSD.org>
CommitDate: 2021-09-07 21:28:08 +0000

    math/eigen3: massage OPTIONs

    Existing OPTIONs pull in too many dependencies -- Eigen is a template
    library and doesn't **need** any of the libs -- and are overly-specific,
    like requiring a particular BLAS implementation.

    PR:             257321 251842
    Reported by:    alt2600@icloud.com

 UPDATING             | 18 ++++++++++++++++++
 math/eigen3/Makefile | 16 ++++++++++------
 2 files changed, 28 insertions(+), 6 deletions(-)