Bug 257322 - net/syncthing: workaround for issue reported in bug #257302
Summary: net/syncthing: workaround for issue reported in bug #257302
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-07-22 04:45 UTC by Alex Vasylenko
Modified: 2021-08-28 01:51 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (swills)


Attachments
skip over non-mcast/down/ipfw0 netif when joining (503 bytes, patch)
2021-07-22 04:45 UTC, Alex Vasylenko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Vasylenko 2021-07-22 04:45:34 UTC
Created attachment 226598 [details]
skip over non-mcast/down/ipfw0 netif when joining

net/syncthing can panic FreeBSD 12.2-RELEASE-p7 GENERIC amd64 when it attempts to perform IPv6 multicast join on ipfw0 interface.

please consider including attached patch until kernel grows some resilience against such nonsensical actions.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-22 06:16:15 UTC
Thank you for the report and patch Alex

What is the user impact of this (other than, of course, the lack of a panic), with respect to syncthing functionality changes, if any, for users with this setup?
Comment 2 Alex Vasylenko 2021-07-22 16:01:07 UTC
Proposed patch has no impact on app's function
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2021-07-23 04:12:40 UTC
(In reply to Alex Vasylenko from comment #2)

Thanks Alex
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-08-28 01:47:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=57a3995a942c59fa51caa39552b290243e957613

commit 57a3995a942c59fa51caa39552b290243e957613
Author:     Steve Wills <swills@FreeBSD.org>
AuthorDate: 2021-07-23 00:41:47 +0000
Commit:     Steve Wills <swills@FreeBSD.org>
CommitDate: 2021-08-28 01:45:42 +0000

    net/syncthing: update to 1.18.1 [0]

    While here, work around multicast issue until all supported versions
    have the fix [1]

    PR:             257322 [1]
    Obtained from:  Alex Vasylenko <lxv@omut.org> [1]

 net/syncthing/Makefile                                       |  2 +-
 net/syncthing/distinfo                                       |  6 +++---
 .../files/patch-syncthing_lib_beacon_multicast.go (new)      | 12 ++++++++++++
 3 files changed, 16 insertions(+), 4 deletions(-)
Comment 5 Steve Wills freebsd_committer freebsd_triage 2021-08-28 01:51:23 UTC
Committed, thanks!