Bug 257431 - textproc/lowdown: Does not fully respect LOCALBASE
Summary: textproc/lowdown: Does not fully respect LOCALBASE
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-26 09:04 UTC by John Marshall
Modified: 2021-08-31 03:04 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bapt)


Attachments
Patch port Makefile to pass PREFIX to configure script (564 bytes, patch)
2021-07-26 09:04 UTC, John Marshall
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marshall 2021-07-26 09:04:49 UTC
Created attachment 226709 [details]
Patch port Makefile to pass PREFIX to configure script

The lowdown configure script sets PREFIX="/usr/local" which forces some of the files to be staged to ${STAGEDIR}/usr/local instead of ${STAGEDIR}${LOCALBASE}, resulting in the port install target not finding those files.

The attached patch adds CONFIGURE_ARGS+= PREFIX=${PREFIX} to the port's Makefile to force the desired ${STAGEDIR}${LOCALBASE} destination for all of the port's files. Also add blank line to keep BUILD_DEPENDS separate for portlint(1).

Maybe this is not the canonical way to fix this (do we need to 'patch' the configure script instead?) but "it works for me" and it's a simple solution.
Comment 1 commit-hook freebsd_committer 2021-08-03 16:47:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bf122ad7c4e464495762396c840580ac1aa90c5c

commit bf122ad7c4e464495762396c840580ac1aa90c5c
Author:     Baptiste Daroussin <bapt@FreeBSD.org>
AuthorDate: 2021-08-03 16:45:54 +0000
Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
CommitDate: 2021-08-03 16:45:54 +0000

    textproc/lowdown: respect PREFIX

    PR:             257431
    Submitted by:   John Marshall <john@jmarshall.id.au>

 textproc/lowdown/Makefile | 1 +
 1 file changed, 1 insertion(+)
Comment 2 John Marshall 2021-08-31 03:04:02 UTC
(In reply to commit-hook from comment #1)
Is this bug still open waiting for a response from me?

All works fine since bapt@ committed the patch.  Thank you!