Bug 257440 - audio/strawberry: Changed default options and added dep
Summary: audio/strawberry: Changed default options and added dep
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-26 23:31 UTC by Daniel Menelkir
Modified: 2021-08-01 11:01 UTC (History)
1 user (show)

See Also:
menelkir: maintainer-feedback+


Attachments
v1 (823 bytes, patch)
2021-07-26 23:31 UTC, Daniel Menelkir
no flags Details | Diff
updated patch (1.05 KB, patch)
2021-07-31 19:16 UTC, Li-Wen Hsu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Menelkir 2021-07-26 23:31:42 UTC
Created attachment 226723 [details]
v1

* Changed the default options for audio to ALSA
* Added databases/qt5-sqldrivers-sqlite3 as a LIB_DEPEND. It'll be installed automatically if you use something like KDE, but straberry will fail to load if you use a minimalist WM for example.
Comment 1 Li-Wen Hsu freebsd_committer 2021-07-31 19:16:05 UTC
Created attachment 226823 [details]
updated patch

(In reply to Daniel Menelkir from comment #0)
Thanks for the patch, here are some minor adjustments:
- Bump PORTREVISION as the content of the package changed.
- We can use USE_QT+=sql-sqlite3 for databases/qt5-sqldrivers-sqlite3

Please check this.
Comment 2 Daniel Menelkir 2021-08-01 09:14:24 UTC
(In reply to Li-Wen Hsu from comment #1)

I've forgot to bump PORTREVISION, sorry.
About the USE_QT, it looks right, I've just failed at my homework (I totally forgot about checking USE_QT for the sqlite3). 
I think it's pretty good, thanks!
Comment 3 commit-hook freebsd_committer 2021-08-01 11:01:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=43f89c81129bc2ad3b1bc21a70646d7bd75c374d

commit 43f89c81129bc2ad3b1bc21a70646d7bd75c374d
Author:     Daniel Menelkir <menelkir@itroll.org>
AuthorDate: 2021-08-01 10:59:04 +0000
Commit:     Li-Wen Hsu <lwhsu@FreeBSD.org>
CommitDate: 2021-08-01 11:00:24 +0000

    audio/strawberry: Change default audio option and add LIB_DEPEND

    * Changed the default options for audio to ALSA
    * Added databases/qt5-sqldrivers-sqlite3 as a LIB_DEPEND.
      It'll be installed automatically if you use something like KDE,
      but straberry will fail to load if you use a minimalist WM for example.

    PR:             257440

 audio/strawberry/Makefile | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)