Bug 257489 (cmake-3.21.1, cmake-3.21.2) - [exp-run] Update cmake to 3.21.2
Summary: [exp-run] Update cmake to 3.21.2
Status: Closed FIXED
Alias: cmake-3.21.1, cmake-3.21.2
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-29 13:05 UTC by Tobias C. Berner
Modified: 2021-09-20 05:48 UTC (History)
1 user (show)

See Also:
antoine: exp-run+


Attachments
v1 (3.73 KB, patch)
2021-07-29 13:05 UTC, Tobias C. Berner
no flags Details | Diff
v1' (3.79 KB, patch)
2021-09-09 18:37 UTC, Tobias C. Berner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias C. Berner freebsd_committer freebsd_triage 2021-07-29 13:05:15 UTC
Created attachment 226778 [details]
v1

Moin moin

kde@ would like to aks for the next exp-run for cmake already. The patch is attached, and can also be found here:
https://people.freebsd.org/~tcberner/patches/0001-devel-cmake-update-to-3.21.1.patch

(The changelog does not seem to warrant an exp-run, the code diff does).


mfg Tobias
Comment 2 commit-hook freebsd_committer freebsd_triage 2021-08-01 07:37:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d8a7f486b1d060f32c074c66c4abaab223536beb

commit d8a7f486b1d060f32c074c66c4abaab223536beb
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2021-08-01 07:35:37 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-08-01 07:35:40 +0000

    editors/cpeditor: add workaround for cmake 3.21.1

    CMake Error:
      Running
       '/usr/local/bin/ninja' '-C' '/wrkdirs/usr/ports/editors/cpeditor/work/.build' '-t' 'recompact'
      failed with:
       ninja: error: build.ninja:824: multiple rules generate ui/ui_appwindow.h [-w dupbuild=err]

    PR:             257489

 editors/cpeditor/Makefile | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2021-08-01 07:40:45 UTC
(In reply to commit-hook from comment #2)
For completeness:
   https://github.com/cpeditor/cpeditor/issues/941
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2021-09-09 18:37:28 UTC
Created attachment 227792 [details]
v1'
Comment 5 Tobias C. Berner freebsd_committer freebsd_triage 2021-09-09 18:39:24 UTC
In the meantime 3.21.2 has been released -- the patch is attached as v1', and can also be found here:
https://people.freebsd.org/~tcberner/patches/0001-devel-cmake-update-to-3.21.2.patch


mfg Tobias
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2021-09-19 06:58:24 UTC
Exp-run looks fine
Comment 7 Tobias C. Berner freebsd_committer freebsd_triage 2021-09-20 05:48:04 UTC
Committed. Thanks for the exp-run.
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-09-20 05:48:40 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e4c97b26769db0755a58aeb3f130dafc57506f97

commit e4c97b26769db0755a58aeb3f130dafc57506f97
Author:     Tobias C. Berner <tcberner@FreeBSD.org>
AuthorDate: 2021-07-29 13:02:32 +0000
Commit:     Tobias C. Berner <tcberner@FreeBSD.org>
CommitDate: 2021-09-20 05:47:33 +0000

    devel/cmake: update to 3.21.2

    Changelog:
            https://cmake.org/cmake/help/v3.21/release/3.21.html#id1
            https://cmake.org/cmake/help/v3.21/release/3.21.html#id23

    PR:             257489
    Exp-run by:     antoine

 devel/cmake-doc/Makefile | 2 +-
 devel/cmake-gui/Makefile | 2 +-
 devel/cmake/Makefile     | 2 +-
 devel/cmake/distinfo     | 6 +++---
 devel/cmake/pkg-plist    | 5 ++++-
 5 files changed, 10 insertions(+), 7 deletions(-)