Bug 257559 - net/openldap24-server - refuses to build with ports ssl.
Summary: net/openldap24-server - refuses to build with ports ssl.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-02 12:40 UTC by robbak
Modified: 2021-08-02 15:27 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (delphij)

Attachments
Patch to fix the logic of the SSL + OPTION FETCH .if statement. (610 bytes, patch)
2021-08-02 12:40 UTC, robbak 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description robbak 2021-08-02 12:40:31 UTC 
Created attachment 226876 [details]
Patch to fix the logic of the SSL + OPTION FETCH .if statement.

Port refuses to build if ports ssl is in use, regardless of whether OPTION FETCH is selected. Build error:

===>  Cleaning for openldap-client-2.4.59_1
===>  openldap-client-2.4.59_1 is marked as broken: using OpenSSL from ports
and OPTION FETCH together is not supported.

Options:

            ┌───────────────────────── openldap-client-2.4.59_1 ───────────────────────────┐
            │ ┌──────────────────────────────────────────────────────────────────────────┐ │  
            │ │ [ ] DEBUG   Build with debugging support                                 │ │  
            │ │ [x] DOCS    Build and/or install documentation                           │ │  
            │ │ [ ] FETCH   Enable fetch(3) support                                      │ │  
            │ │ [ ] GSSAPI  With GSSAPI support                                          │ │  
            │ └──────────────────────────────────────────────────────────────────────────┘ │  
            ├──────────────────────────────────────────────────────────────────────────────┤  
            │                       <  OK  >            <Cancel>                           │  
            └──────────────────────────────────────────────────────────────────────────────┘  
                                                                                              
My patch, fixing the logic by adding brackets around all the ssl parts:

index 6146a8c82b34..3b72dc62fd46 100644
--- a/net/openldap24-server/Makefile
+++ b/net/openldap24-server/Makefile
@@ -509,7 +509,7 @@ PLIST_SUB+=         OPENLDAP_MAJOR=${OPENLDAP_MAJOR}
 
 .include <bsd.port.pre.mk>
 
-.if ${PORT_OPTIONS:MFETCH} && defined(OPENSSL_INSTALLED) && ${OPENSSL_INSTALLED} != "" || ${SSL_DEFAULT} != base
+.if ${PORT_OPTIONS:MFETCH} && ( defined(OPENSSL_INSTALLED) && ${OPENSSL_INSTALLED} != "" || ${SSL_DEFAULT} != basea )
 BROKEN=        using OpenSSL from ports and OPTION FETCH together is not supported
 . endif
Comment 1 commit-hook freebsd_committer freebsd_triage 2021-08-02 15:27:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=068a856800e69ed12db47f9c8cb93be8e85cb141

commit 068a856800e69ed12db47f9c8cb93be8e85cb141
Author:     Robert Backhaus <robbak@gmail.com>
AuthorDate: 2021-08-02 15:24:15 +0000
Commit:     Xin LI <delphij@FreeBSD.org>
CommitDate: 2021-08-02 15:26:39 +0000

    net/openldap24-server: Fix build with port OpenSSL

    PR:             ports/257559
    Reported by:    many

 net/openldap24-server/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 Xin LI freebsd_committer freebsd_triage 2021-08-02 15:27:25 UTC 
My bad, fixed, thanks for submission.