Bug 257630 - emulators/wine: fix MONO_RUN_DEPENDS
Summary: emulators/wine: fix MONO_RUN_DEPENDS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-05 02:55 UTC by Eric Camachat
Modified: 2021-08-29 07:18 UTC (History)
0 users

See Also:


Attachments
fix wine-mono run depends. (513 bytes, patch)
2021-08-05 02:55 UTC, Eric Camachat
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Camachat 2021-08-05 02:55:48 UTC
Created attachment 226963 [details]
fix wine-mono run depends.

fix wine-mono run depends.
Comment 1 commit-hook freebsd_committer 2021-08-05 15:48:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4224d94ae30a28447c2d3bdc1a3494738bd87dd9

commit 4224d94ae30a28447c2d3bdc1a3494738bd87dd9
Author:     Gerald Pfeifer <gerald@FreeBSD.org>
AuthorDate: 2021-08-05 15:12:00 +0000
Commit:     Gerald Pfeifer <gerald@FreeBSD.org>
CommitDate: 2021-08-05 15:46:42 +0000

    emulators/i386-wine: Fix the dependency on wine-mono

    This non-default, rarely used option was missed in the upgrade to
    Wine 6.0.1 in 3da5204497006152dbc5cbb73fb0e10002e7de6c.

    Also adjust the file name we use in the dependency to the upstream
    change for Wine Mono. [1]

    PR:             257630 [1]
    Submitted by:   Eric Camachat <eric@camachat.org>

 emulators/i386-wine/Makefile.amd64 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 2 Gerald Pfeifer freebsd_committer 2021-08-05 15:49:09 UTC
Thank you for the report and even include a patch!

As you can see, I included that in a fix I already had queued for the
i386-wine port; I have an idea for the wine port itself and hope to get
to that in the next two days or so.
Comment 3 commit-hook freebsd_committer 2021-08-07 10:43:36 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=dc73fd607fb79017cf74182613659ac9c4340bdd

commit dc73fd607fb79017cf74182613659ac9c4340bdd
Author:     Gerald Pfeifer <gerald@FreeBSD.org>
AuthorDate: 2021-08-07 10:42:06 +0000
Commit:     Gerald Pfeifer <gerald@FreeBSD.org>
CommitDate: 2021-08-07 10:43:01 +0000

    emulators/wine: Make the dependency on wine-mono generic

    Instead of hard coding the actual version number use a generic
    dependency on simply the port. This makes maintenance easier and
    reduces the chance for mistakes.

    (We have been using this in emulators/wine-devel for some four
    months already since 996345a04d856fdc863ddce257b8d98da8074d6c .)

    PR:             257630

 emulators/wine/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Gerald Pfeifer freebsd_committer 2021-08-07 10:48:01 UTC
As you can see I went for a more general approach to avoid such cases
as you ran into and kindly reported in the future.

Hope this works for you, too?

Thanks again!
Comment 5 commit-hook freebsd_committer 2021-08-29 07:18:35 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=18fcc610bf93b40517bdb3f3ba945659a70cb6d0

commit 18fcc610bf93b40517bdb3f3ba945659a70cb6d0
Author:     Gerald Pfeifer <gerald@FreeBSD.org>
AuthorDate: 2021-08-29 07:17:25 +0000
Commit:     Gerald Pfeifer <gerald@FreeBSD.org>
CommitDate: 2021-08-29 07:17:41 +0000

    emulators/i386-wine: Make the dependency on wine-mono generic

    Instead of hard coding the actual version number use a generic
    dependency on simply the port. This makes maintenance easier and
    reduces the chance for mistakes.

    This ports over commit dc73fd607fb79017cf74182613659ac9c4340bdd
    from the emulators/wine port:

    PR:             257630

 emulators/i386-wine/Makefile.amd64 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)