Bug 257651 - emulators/wine, emulators/wine-devel: XAudio2 no longer depends on OpenAL
Summary: emulators/wine, emulators/wine-devel: XAudio2 no longer depends on OpenAL
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks: 257533
  Show dependency treegraph
 
Reported: 2021-08-06 07:53 UTC by Alex S
Modified: 2021-08-10 07:48 UTC (History)
0 users

See Also:
gerald: maintainer-feedback+


Attachments
pkg-plist patch for wine (4.30 KB, patch)
2021-08-06 07:53 UTC, Alex S
no flags Details | Diff
pkg-plist patch for wine-devel (6.08 KB, patch)
2021-08-06 07:54 UTC, Alex S
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex S 2021-08-06 07:53:52 UTC
Created attachment 226982 [details]
pkg-plist patch for wine

Since commit 3e390b1aafff47df63376a8ca4293c515d74f4ba, to be precise.
Comment 1 Alex S 2021-08-06 07:54:35 UTC
Created attachment 226983 [details]
pkg-plist patch for wine-devel
Comment 2 Gerald Pfeifer freebsd_committer 2021-08-07 21:00:47 UTC
Thank you, Alex, I'll add both of those in the next of days.

Out of curiosity, how did you spot this? Due to PR 220950 regular testing
sadly does not discover it for me.
Comment 3 Alex S 2021-08-08 04:25:33 UTC
(In reply to Gerald Pfeifer from comment #2)

> Out of curiosity, how did you spot this?

I noticed a few leftover shared libraries in /usr/local/lib/wine after `pkg remove wine-devel` while testing patches for bug 257533.

(Why they were there? pkg tends to simply leave old files in place if one installs packages directly from the local filesystem in one `pkg install` step, which I used to do. Nowadays if I want to reinstall a package, I explicitly `pkg remove -f` it first.)
Comment 4 commit-hook freebsd_committer 2021-08-08 09:20:29 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=835981dbc56d281ba8cc9ac1433536f3e448491b

commit 835981dbc56d281ba8cc9ac1433536f3e448491b
Author:     Gerald Pfeifer <gerald@FreeBSD.org>
AuthorDate: 2021-08-08 09:19:40 +0000
Commit:     Gerald Pfeifer <gerald@FreeBSD.org>
CommitDate: 2021-08-08 09:19:40 +0000

    emulators/wine-devel: XAudio2 no longer depends on OpenAL

    Since upstream commit 3e390b1aafff47df63376a8ca4293c515d74f4ba on
    2019-02-20 XAudio2 uses FAudio (which already is an unconditional
    dependency) and no longer depends on OpenAL, so adjust the packing
    list accordingly. [1]

    We did not detect this via regular testing due to false negatives
    in Mk/Scripts/check-stagedir.sh in the presence of %%OPTION%%s in
    pkg-plist. [2]

    PR:             257651 [1], 220950 [2]
    Submitted by:   Alex S <iwtcex@gmail.com> [1]

 emulators/wine-devel/Makefile  |  2 +-
 emulators/wine-devel/pkg-plist | 92 +++++++++++++++++++++---------------------
 2 files changed, 47 insertions(+), 47 deletions(-)
Comment 5 commit-hook freebsd_committer 2021-08-10 07:44:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3f3a0267078b3438d5453b5a4bf230cf282ca0e0

commit 3f3a0267078b3438d5453b5a4bf230cf282ca0e0
Author:     Gerald Pfeifer <gerald@FreeBSD.org>
AuthorDate: 2021-08-10 07:43:27 +0000
Commit:     Gerald Pfeifer <gerald@FreeBSD.org>
CommitDate: 2021-08-10 07:43:27 +0000

    emulators/wine: XAudio2 no longer depends on OpenAL

    Since upstream commit 3e390b1aafff47df63376a8ca4293c515d74f4ba on
    2019-02-20 XAudio2 uses FAudio (which already is an unconditional
    dependency) and no longer depends on OpenAL, so adjust the packing
    list accordingly. [1]

    We did not detect this via regular testing due to false negatives
    in Mk/Scripts/check-stagedir.sh in the presence of %%OPTION%%s in
    pkg-plist. [2]

    PR:             257651 [1], 220950 [2]
    Submitted by:   Alex S <iwtcex@gmail.com> [1]

 emulators/wine/Makefile  |  2 +-
 emulators/wine/pkg-plist | 92 ++++++++++++++++++++++++------------------------
 2 files changed, 47 insertions(+), 47 deletions(-)
Comment 6 Gerald Pfeifer freebsd_committer 2021-08-10 07:48:07 UTC
Thanks for reporting this and providing patches, Alex.

Grr ... I just realized I failed to set you as --author when committing;
apologies for that. :-(