Bug 257736 - devel/p5-Devel-NYTProf: Update to 6.10
Summary: devel/p5-Devel-NYTProf: Update to 6.10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL: https://metacpan.org/release/JKEENAN/...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-10 12:07 UTC by Sergei Vyshenski
Modified: 2021-08-23 20:46 UTC (History)
3 users (show)

See Also:
vovkasm: maintainer-feedback+

Attachments
"git diff" to update the port (2.03 KB, patch)
2021-08-10 12:07 UTC, Sergei Vyshenski 		no flags Details | Diff
patch to update the port (2.03 KB, patch)
2021-08-23 18:21 UTC, Sergei Vyshenski 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergei Vyshenski 2021-08-10 12:07:41 UTC 
Created attachment 227078 [details]
"git diff" to update the port

- Update 6.06 -> 6.10
Changes: https://metacpan.org/release/JKEENAN/Devel-NYTProf-6.10/source/Changes

- "portlint -AC" gives non-relevant warns.
- "portclippy Makefile" is happy.
- Tested with:
13.0-RELEASE-p3
pkg 1.17.1
poudriere 3.3.6
perl 5.32.1
openssl 1.1.1k
ssl=base
- built-in perl tests in a clean poudriere jail say: PASS.
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2021-08-23 15:47:16 UTC 
Hello,

Please use DISTVERSION instead of PORTVERSION:
---
Example 2. Using DISTVERSION

When the version only contains numbers separated by dots, dashes or underscores, use DISTVERSION.

PORTNAME=   nekoto
DISTVERSION=	1.2-4

It will generate a PORTVERSION of 1.2.4.
---
https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-naming

Thanks
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2021-08-23 16:10:36 UTC 
- 'poudriere testport' ok on all supported FreeBSD versions (amd64 and i386)
- 'make test' in poudriere clean envirorement: PASS
Comment 3 Sergei Vyshenski 2021-08-23 18:21:32 UTC 
Created attachment 227387 [details]
patch to update the port

A new patch with DISTVERSION.
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2021-08-23 20:37:13 UTC 
Port ready to be committed. Waiting for maintainer approval.
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2021-08-23 20:39:42 UTC 
(In reply to Nuno Teixeira from comment #4)
Forget it... We have maitainer aproval
Comment 6 Vladimir Timofeev 2021-08-23 20:42:30 UTC 
Approved. Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2021-08-23 20:45:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b3ee81186ed0b585ebbcf8da904b57476825e749

commit b3ee81186ed0b585ebbcf8da904b57476825e749
Author:     Sergei Vyshenski <svysh.fbsd@gmail.com>
AuthorDate: 2021-08-23 20:42:20 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2021-08-23 20:42:20 +0000

    devel/p5-Devel-NYTProf: Update to 6.10

    ChangeLog: https://metacpan.org/release/JKEENAN/Devel-NYTProf-6.10/source/Changes

    PR:             257736

 devel/p5-Devel-NYTProf/Makefile  | 5 +++--
 devel/p5-Devel-NYTProf/distinfo  | 6 +++---
 devel/p5-Devel-NYTProf/pkg-plist | 3 ++-
 3 files changed, 8 insertions(+), 6 deletions(-)
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2021-08-23 20:46:15 UTC 
Committed thanks!