Bug 257811 - ftp/bftpd: Update port to 6.0
Summary: ftp/bftpd: Update port to 6.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guangyuan Yang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-13 15:43 UTC by Jesse Smith
Modified: 2021-08-14 00:30 UTC (History)
1 user (show)

See Also:


Attachments
Update ftp/bftpd to version 6.0 provided by upstream (859 bytes, text/plain)
2021-08-13 15:43 UTC, Jesse Smith
no flags Details
Updated patch to bring ftp/bftpd port up to date (1015 bytes, patch)
2021-08-13 20:32 UTC, Jesse Smith
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Smith 2021-08-13 15:43:32 UTC
Created attachment 227162 [details]
Update ftp/bftpd to version 6.0 provided by upstream

The attached patch updates the ftp/bftpd port to match the upstream Bftpd 6.0 release. The changes in the new version are minor and include just a handful of bug fixes.

Since the ftp/bftpd port is currently unmaintained, I'd like to volunteer to take over this FreeBSD port.
Comment 1 Guangyuan Yang freebsd_committer 2021-08-13 19:36:49 UTC
(In reply to jsmith from comment #0)

Hi! Please feel free to set your email in MAINTAINER= field. Also, it is recommended to set your name in https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=account so that we can use this to properly credit you in commits.

Please submit Git patches in the future, thanks!
Comment 2 Jesse Smith 2021-08-13 20:00:27 UTC
Thanks, I'll add my e-mail to the port and re-submit. And I've updated my Bugzilla information.

I'm curious about the request of using git to create patches. I used the method in the Porter's Handbook which says, when not working with a copy of the entire ports tree, to copy the directory of the port and perform a "diff -ruN port.bak/ port/" to generate the patch. This is what I did, so is the Handbook out of date?

Th section I'm referring to to quoted below:

"copy the contents of the port to an entire different directory and use the result of the recursive diff(1) output of the new and old ports directories (for example, if the modified port directory is called superedit and the original is in our tree as superedit.bak, then save the result of diff -ruN superedit.bak superedit). Either unified or context diff is fine, but port committers generally prefer unified diffs."

This is information no longer accurate?
Comment 3 Jesse Smith 2021-08-13 20:32:15 UTC
Created attachment 227167 [details]
Updated patch to bring ftp/bftpd port up to date

This patch replaces the previous one. Only new change is adjusting the maintainer field to adopt the port.
Comment 4 Guangyuan Yang freebsd_committer 2021-08-13 22:45:25 UTC
(In reply to Jesse Smith from comment #2)

Thanks for the attention to detail! Not to discuss too much about the policy here, though these sections haven't been updated for a while. Since we moved to git, most patches are from git diff or git format-patch, and I think committers generally prefer that. But until the handbook is changed, this remains a recommended item :)
Comment 5 commit-hook freebsd_committer 2021-08-14 00:25:16 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3f82468681a63057a4f9cc4055f94afb19876c89

commit 3f82468681a63057a4f9cc4055f94afb19876c89
Author:     Jesse Smith <jsmith@resonatingmedia.com>
AuthorDate: 2021-08-14 00:24:58 +0000
Commit:     Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-08-14 00:24:58 +0000

    ftp/bftpd: Update to 6.0 and take maintainership

    PR:             257811

 ftp/bftpd/Makefile | 4 ++--
 ftp/bftpd/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 6 Guangyuan Yang freebsd_committer 2021-08-14 00:30:38 UTC
Committed, thanks!