Created attachment 227162 [details]
Update ftp/bftpd to version 6.0 provided by upstream
The attached patch updates the ftp/bftpd port to match the upstream Bftpd 6.0 release. The changes in the new version are minor and include just a handful of bug fixes.
Since the ftp/bftpd port is currently unmaintained, I'd like to volunteer to take over this FreeBSD port.
(In reply to jsmith from comment #0)
Hi! Please feel free to set your email in MAINTAINER= field. Also, it is recommended to set your name in https://bugs.freebsd.org/bugzilla/userprefs.cgi?tab=account so that we can use this to properly credit you in commits.
Please submit Git patches in the future, thanks!
Thanks, I'll add my e-mail to the port and re-submit. And I've updated my Bugzilla information.
I'm curious about the request of using git to create patches. I used the method in the Porter's Handbook which says, when not working with a copy of the entire ports tree, to copy the directory of the port and perform a "diff -ruN port.bak/ port/" to generate the patch. This is what I did, so is the Handbook out of date?
Th section I'm referring to to quoted below:
"copy the contents of the port to an entire different directory and use the result of the recursive diff(1) output of the new and old ports directories (for example, if the modified port directory is called superedit and the original is in our tree as superedit.bak, then save the result of diff -ruN superedit.bak superedit). Either unified or context diff is fine, but port committers generally prefer unified diffs."
This is information no longer accurate?
Created attachment 227167 [details]
Updated patch to bring ftp/bftpd port up to date
This patch replaces the previous one. Only new change is adjusting the maintainer field to adopt the port.
(In reply to Jesse Smith from comment #2)
Thanks for the attention to detail! Not to discuss too much about the policy here, though these sections haven't been updated for a while. Since we moved to git, most patches are from git diff or git format-patch, and I think committers generally prefer that. But until the handbook is changed, this remains a recommended item :)
A commit in branch main references this bug:
Author: Jesse Smith <firstname.lastname@example.org>
AuthorDate: 2021-08-14 00:24:58 +0000
Commit: Guangyuan Yang <ygy@FreeBSD.org>
CommitDate: 2021-08-14 00:24:58 +0000
ftp/bftpd: Update to 6.0 and take maintainership
ftp/bftpd/Makefile | 4 ++--
ftp/bftpd/distinfo | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)