Bug 257889 - net-im/tg_owt missing USE_XORG = xtst
Summary: net-im/tg_owt missing USE_XORG = xtst
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-16 17:55 UTC by Oleh Vinichenko
Modified: 2021-10-20 06:09 UTC (History)
2 users (show)

See Also:
henry.hu.sh: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oleh Vinichenko 2021-08-16 17:55:46 UTC
As in summary, tg_owt appears require x11/libXtst for buiding, so that USE_XORG = ... xtst had to be added.
Excerpt of poudriere build of net-im/tg_owt:

CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find X11 (missing: Xtst)
Call Stack (most recent call first):
  /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/share/cmake/Modules/FindX11.cmake:457 (find_package_handle_standard_args)
  cmake/external.cmake:227 (find_package)
  CMakeLists.txt:171 (link_x11)

manually installing libXtst in poudriere jail build makes tg_owt compilation successful.
Comment 1 Henry Hu 2021-08-19 04:19:31 UTC
Hm, I think you're right: it asks for xtst, and also xext, actually.
On the other hand, the port builds fine in poudriere etc. I suspect xtst and xext are required by other ports, while the build options you set may removed these dependencies.

In general, I agree that both xtst and xext should be added to the USE_XORG list.
Comment 2 Henry Hu 2021-08-19 04:19:53 UTC
See the cmake file for details: https://github.com/desktop-app/tg_owt/blame/master/cmake/external.cmake#L227
Comment 3 Oleh Vinichenko 2021-08-19 04:58:43 UTC
Yes, i did look at upstream cmake, after encountering build failure. Honestly, i would like to have X11 support to be optional in both tg_owt and telegram-desktop but it is another topic.