Bug 257889 - net-im/tg_owt missing USE_XORG = xtst
Summary: net-im/tg_owt missing USE_XORG = xtst
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Gleb Smirnoff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-16 17:55 UTC by Oleh Vinichenko
Modified: 2021-12-10 22:00 UTC (History)
3 users (show)

See Also:
henry.hu.sh: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oleh Vinichenko 2021-08-16 17:55:46 UTC
As in summary, tg_owt appears require x11/libXtst for buiding, so that USE_XORG = ... xtst had to be added.
Excerpt of poudriere build of net-im/tg_owt:

CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find X11 (missing: Xtst)
Call Stack (most recent call first):
  /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/share/cmake/Modules/FindX11.cmake:457 (find_package_handle_standard_args)
  cmake/external.cmake:227 (find_package)
  CMakeLists.txt:171 (link_x11)

manually installing libXtst in poudriere jail build makes tg_owt compilation successful.
Comment 1 Henry Hu 2021-08-19 04:19:31 UTC
Hm, I think you're right: it asks for xtst, and also xext, actually.
On the other hand, the port builds fine in poudriere etc. I suspect xtst and xext are required by other ports, while the build options you set may removed these dependencies.

In general, I agree that both xtst and xext should be added to the USE_XORG list.
Comment 2 Henry Hu 2021-08-19 04:19:53 UTC
See the cmake file for details: https://github.com/desktop-app/tg_owt/blame/master/cmake/external.cmake#L227
Comment 3 Oleh Vinichenko 2021-08-19 04:58:43 UTC
Yes, i did look at upstream cmake, after encountering build failure. Honestly, i would like to have X11 support to be optional in both tg_owt and telegram-desktop but it is another topic.
Comment 4 commit-hook freebsd_committer 2021-11-18 22:10:41 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e4f31ebae421a3c46ca73f6f2c9be78ba9d61568

commit e4f31ebae421a3c46ca73f6f2c9be78ba9d61568
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2021-11-18 04:09:20 +0000
Commit:     Olivier Cochard <olivier@FreeBSD.org>
CommitDate: 2021-11-18 22:04:32 +0000

    net-im/tg_owt: fix dependencies

    - Don't depend on audio backends, as their build is not disabled
    - Explicitly depend on libXtst

    PR:     257889
    PR:     259182

 net-im/tg_owt/Makefile | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
Comment 5 commit-hook freebsd_committer 2021-12-10 22:00:21 UTC
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7cd6ca8fca8fcf62d57fb23e98dcea98542a0580

commit 7cd6ca8fca8fcf62d57fb23e98dcea98542a0580
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2021-11-18 04:09:20 +0000
Commit:     Olivier Cochard <olivier@FreeBSD.org>
CommitDate: 2021-12-10 21:20:36 +0000

    net-im/tg_owt: fix dependencies

    - Don't depend on audio backends, as their build is not disabled
    - Explicitly depend on libXtst

    PR:     257889
    PR:     259182
    (cherry picked from commit e4f31ebae421a3c46ca73f6f2c9be78ba9d61568)

 net-im/tg_owt/Makefile | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)