Bug 257900 - dns/c-ares: Update to 1.17.2
Summary: dns/c-ares: Update to 1.17.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ryan Steinmetz
URL: https://c-ares.haxx.se/changelog.html...
Keywords: security
Depends on:
Blocks:
 
Reported: 2021-08-17 01:53 UTC by Jose Luis Duran
Modified: 2021-08-17 16:30 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (zi)

Attachments
dns/c-ares: Update to 1.17.2 (1.32 KB, patch)
2021-08-17 01:53 UTC, Jose Luis Duran 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Luis Duran freebsd_committer freebsd_triage 2021-08-17 01:53:09 UTC 
Created attachment 227262 [details]
dns/c-ares: Update to 1.17.2

Changelog: https://c-ares.haxx.se/changelog.html#1_17_2
Comment 1 Juraj Lutter freebsd_committer freebsd_triage 2021-08-17 06:14:20 UTC 
The patch is not correct. See review D31433 for details.
Comment 2 Ryan Steinmetz freebsd_committer freebsd_triage 2021-08-17 16:17:32 UTC 
Port updated to 1.17.2.
Comment 3 Juraj Lutter freebsd_committer freebsd_triage 2021-08-17 16:22:37 UTC 
(In reply to Ryan Steinmetz from comment #2)
Please also see review D31433. That small improvement will make www/node14 build. updated www/node14 is needed for making www/kibana7 work.
Comment 4 Jose Luis Duran freebsd_committer freebsd_triage 2021-08-17 16:30:47 UTC 
(In reply to Juraj Lutter from comment #3)

The "small improvement" is still being discussed by c-ares (https://github.com/c-ares/c-ares/pull/417), most likely it will produce another version bump, and we'll update accordingly.

In the meantime, for node, the workaround seems to be to include the private header, outside the scope of c-ares (https://github.com/nodejs/node/pull/39739). The bugzilla-submitted node patches reflect this arguably ugly hack.

Again, it will likely produce another version bump for node, we should remove the extra file, and go back to normal.

Thank you for keeping an eye on this issue!