Bug 258015 - ports-mgmt/portlint: Add fatal error: USE_GCC=any is deprecated
Summary: ports-mgmt/portlint: Add fatal error: USE_GCC=any is deprecated
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-23 20:31 UTC by Yuri Victorovich
Modified: 2021-10-15 17:50 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2021-08-23 20:31:14 UTC
Mk/bsd.gcc.mk says:

>  # (USE_GCC=any is deprecated, must not be used for new ports, and should
>  # be migrated to USE_GCC=yes or completely removed if possible.)
Comment 1 Gerald Pfeifer freebsd_committer 2021-08-26 09:02:27 UTC
Thank you for proposing this, Yuri!

Can you give me a week or two, please?

I'm looking into possibly removingg USE_GCC=any completely which would
obsolete the need for such a warning in portlint.
Comment 2 Yuri Victorovich freebsd_committer 2021-08-26 16:31:29 UTC
(In reply to Gerald Pfeifer from comment #1)

Thank you, Gerald.
Comment 3 commit-hook freebsd_committer 2021-09-03 18:03:31 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=15ace930f6cfd368517018d6bc132ac2c4145ae8

commit 15ace930f6cfd368517018d6bc132ac2c4145ae8
Author:     Gerald Pfeifer <gerald@FreeBSD.org>
AuthorDate: 2021-09-03 18:01:29 +0000
Commit:     Gerald Pfeifer <gerald@FreeBSD.org>
CommitDate: 2021-09-03 18:02:08 +0000

    math/gismo: Replace USE_GCC=any with USE_GCC=yes

    Since commit 96c17633d90386b5bcf8637bcba99a677184db85 in May 2021
    USE_GCC=any is just an old (and odd) way of writing USE_GCC=yes
    and was deprecated even before. Replace it with USE_GCC=yes.

    PR:             258015

 math/gismo/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Gerald Pfeifer freebsd_committer 2021-09-03 18:08:56 UTC
(In reply to commit-hook from comment #3)
> math/gismo: Replace USE_GCC=any with USE_GCC=yes

This is the last port in the tree where USE_GCC=any sneaked in again.

Next I'll strengthen the documentation in Mk/bsd.gcc.mk and a little
later I'll remove USE_GCC=any to begin with (which means portlint does
not need to concern itself about warning about it).
Comment 5 commit-hook freebsd_committer 2021-09-23 18:21:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e6d30d653311797923afa1225eff167d8a15f679

commit e6d30d653311797923afa1225eff167d8a15f679
Author:     Gerald Pfeifer <gerald@FreeBSD.org>
AuthorDate: 2021-09-23 18:18:21 +0000
Commit:     Gerald Pfeifer <gerald@FreeBSD.org>
CommitDate: 2021-09-23 18:20:23 +0000

    Mk/bsd.gcc.mk: Strongly discourage USE_GCC=any

    PR:             258015

 Mk/bsd.gcc.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 6 Gerald Pfeifer freebsd_committer 2021-09-23 18:24:42 UTC
I'll wait for the next quarterly branch (in about two weeks) and plan
on removing support for USE_GCC=any then.

That way conservative users, in particular those who have out of tree 
ports have another quarter to adjust, and of course I'll make the change
only after ensuring no new instances of USE_GCC=any have appeared in the
tree.
Comment 7 commit-hook freebsd_committer 2021-10-15 17:49:05 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3d1ff1fdae49931a3572adc81519f3a277a77253

commit 3d1ff1fdae49931a3572adc81519f3a277a77253
Author:     Gerald Pfeifer <gerald@FreeBSD.org>
AuthorDate: 2021-10-15 17:43:11 +0000
Commit:     Gerald Pfeifer <gerald@FreeBSD.org>
CommitDate: 2021-10-15 17:47:53 +0000

    Mk/bsd.gcc.mk: Remove USE_GCC=any

    We have recommended against USE_GCC=any for a while, and as of more
    recently it was completely equivalent to USE_GCC=yes.

    With (ancient versions of) GCC hardly available in the base system
    of FreeBSD systems at this point, there's unlikely to be a use case
    to reintroduce it, so remove the few remaining traces.

    PR:             258015

 Mk/bsd.gcc.mk | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
Comment 8 Gerald Pfeifer freebsd_committer 2021-10-15 17:50:31 UTC
As promised: USE_GCC=any is now a thing of the past.

Thanks for pointing out the portlint enhancement which ultimately pushed
its removal. :)