Bug 258073 - devel/spdlog: Package is broken: include/spdlog/fmt/fmt.h includes spdlog/fmt/bundled/core.h which isn't installed
Summary: devel/spdlog: Package is broken: include/spdlog/fmt/fmt.h includes spdlog/fmt...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vanilla I. Shu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-27 03:16 UTC by Yuri Victorovich
Modified: 2021-08-28 09:57 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (vanilla)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2021-08-27 03:16:44 UTC 
The port deletes spdlog/fmt/bundled but it is included in the installed header.

Also it is strange that SPDLOG_FMT_EXTERNAL is given to cmake but the bundled fmt is still installed.
Comment 1 Vanilla I. Shu freebsd_committer freebsd_triage 2021-08-27 08:14:02 UTC 
(In reply to Yuri Victorovich from comment #0)

It seems ok on my box,

the 'post-extract' section can delete, it's not necessary now.
(according CMakeLists.txt, it's handle by SPDLOG_FMT_EXTERNAL flag now).
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2021-08-27 08:47:05 UTC 
I am trying to build the project muq2 (https://bitbucket.org/mituq/muq2) and it fails to compile the test for spdlog:


> In file included from src.cxx:2:
> In file included from /usr/local/include/spdlog/spdlog.h:12:
> In file included from /usr/local/include/spdlog/common.h:36:
> /usr/local/include/spdlog/fmt/fmt.h:22:14: fatal error: 'spdlog/fmt/bundled/core.h' file not found
> #    include <spdlog/fmt/bundled/core.h>
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
Comment 3 Vanilla I. Shu freebsd_committer freebsd_triage 2021-08-28 09:57:26 UTC 
(In reply to Yuri Victorovich from comment #2)

I think you should add '-DSPDLOG_FMT_EXTERNAL=1' to muq2's CFLAGS.