Bug 258112 - comms/direwolf: fix build with new gpsd
Summary: comms/direwolf: fix build with new gpsd
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Charlie Li
URL:
Keywords:
Depends on: 258109
Blocks:
  Show dependency tree / graph
 
Reported: 2021-08-28 00:57 UTC by Steve Wills
Modified: 2022-03-14 00:35 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (hamradio)

Attachments
patch to fix build with new gpsd (35.11 KB, patch)
2021-08-28 00:57 UTC, Steve Wills 		no flags Details | Diff
patch to fix build with new gpsd against Direwolf 1.6 (3.98 KB, patch)
2022-01-29 01:12 UTC, Diane Bruce 		no flags Details | Diff
v3 (6.12 KB, patch)
2022-03-05 13:41 UTC, Charlie Li 		no flags Details | Diff
v3+1 (3.13 KB, patch)
2022-03-05 13:55 UTC, Charlie Li 		no flags Details | Diff
v4 (6.40 KB, patch)
2022-03-05 19:49 UTC, Charlie Li 		no flags Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2021-08-28 00:57:32 UTC 
Created attachment 227502 [details]
patch to fix build with new gpsd
Comment 1 Diane Bruce freebsd_committer freebsd_triage 2022-01-29 01:12:30 UTC 
Created attachment 231417 [details]
patch to fix build with new gpsd against Direwolf 1.6

Looks like I clobbered this PR with two others.


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260337
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=260483

I don't believe this is needed
libudev.so:devel/libudev-devd
Comment 2 Charlie Li freebsd_committer freebsd_triage 2022-03-05 03:50:11 UTC 
Upstream properly implemented gpsd-3.23 support: https://github.com/wb2osz/direwolf/commit/42314b7219ec266697396c7a4b61afe91be9b92c
Comment 3 Charlie Li freebsd_committer freebsd_triage 2022-03-05 13:41:37 UTC 
Created attachment 232260 [details]
v3

Use upstream commits for gpsd-3.23 support. Bump PORTREVISION due to API breakage and functional changes.

Note: this fails testport at stage-qa due to USES=shebangfix running before the PATCH_SITES stage. Additional patch coming to work around this for now.
Comment 4 Charlie Li freebsd_committer freebsd_triage 2022-03-05 13:55:10 UTC 
Created attachment 232261 [details]
v3+1

Work around USES=shebangfix bug. Apply on top of v3.
Comment 5 Charlie Li freebsd_committer freebsd_triage 2022-03-05 19:49:15 UTC 
Created attachment 232272 [details]
v4

Use TARGET_ORDER_OVERRIDE for shebangfix
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-03-14 00:33:46 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=d7758c90f563430207d788f65b7f87cf91f20c8e

commit d7758c90f563430207d788f65b7f87cf91f20c8e
Author:     Charlie Li <vishwin@FreeBSD.org>
AuthorDate: 2022-03-14 00:27:58 +0000
Commit:     Steve Wills <swills@FreeBSD.org>
CommitDate: 2022-03-14 00:31:48 +0000

    comms/direwolf: fix build with new gpsd

    PR:             258112

 comms/direwolf/Makefile                        | 33 ++++++++++---------
 comms/direwolf/distinfo                        | 14 +++++++-
 comms/direwolf/files/patch-scripts_dw-start.sh | 44 +++++++++++---------------
 comms/direwolf/pkg-descr                       |  2 ++
 4 files changed, 50 insertions(+), 43 deletions(-)
Comment 7 Steve Wills freebsd_committer freebsd_triage 2022-03-14 00:35:20 UTC 
Committed, thanks!