Bug 258367 - textproc/ripgrep: limit RUSTC_BOOTSTRAP impact (SIMD option)
Summary: textproc/ripgrep: limit RUSTC_BOOTSTRAP impact (SIMD option)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
Keywords: patch
Depends on:
Reported: 2021-09-08 15:08 UTC by Jan Beich
Modified: 2021-09-09 16:14 UTC (History)
1 user (show)

See Also:
petteri.valkonen: maintainer-feedback+

v1 (apply via "git am") (1007 bytes, patch)
2021-09-08 15:08 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2021-09-08 15:08:19 UTC
Created attachment 227764 [details]
v1 (apply via "git am")

With Rust >= 1.50 (since ports 6bebfaa8a06c) RUSTC_BOOTSTRAP=1 can be limited to RUSTC_BOOTSTRAP=<crate>,<crate>,... as described in https://github.com/rust-lang/rust/pull/77802 This slightly increases maintenance (have to track which crates need RUSTC_BOOTSTRAP) but reduces the scope of unstable features. Doesn't seem to affect runtime i.e., the binary appears to be identical (tested on 12.2 amd64).

$ sha256 rg*
SHA256 (rg-new) = 2989083ba356013dc3b8b484470fd41a9660a4cf46d8abdc2cddad5b728daf10
SHA256 (rg-old) = 2989083ba356013dc3b8b484470fd41a9660a4cf46d8abdc2cddad5b728daf10
Comment 1 Petteri Valkonen 2021-09-09 14:34:02 UTC
LGTM. Should we also remove the comment about ’packed_simd_2’ since it’s now evident which crates need RUSTC_BOOTSTRAP?
Comment 2 commit-hook freebsd_committer 2021-09-09 16:12:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a2583240def2008f987f68e24075fddd918d4089

commit a2583240def2008f987f68e24075fddd918d4089
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-09-08 14:38:29 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-09-09 16:07:41 +0000

    textproc/ripgrep: limit unstable rust features after 6bebfaa8a06c

    Drop stale comment as it's now evident which crates need unstable features.

    PR:             258367
    Approved by:    Petteri Valkonen (maintainer)

 textproc/ripgrep/Makefile | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Comment 3 Jan Beich freebsd_committer 2021-09-09 16:13:33 UTC
(In reply to Petteri Valkonen from comment #1)
> Should we also remove the comment about ’packed_simd_2’ since it’s
> now evident which crates need RUSTC_BOOTSTRAP?

Done. It needed a complete rewording but I had no cycles to bother. ;)
Stabilization seems to be stalled (related bugs closed) but maybe not completely per https://github.com/rust-lang/portable-simd/issues/146