Created attachment 227764 [details]
v1 (apply via "git am")
With Rust >= 1.50 (since ports 6bebfaa8a06c) RUSTC_BOOTSTRAP=1 can be limited to RUSTC_BOOTSTRAP=<crate>,<crate>,... as described in https://github.com/rust-lang/rust/pull/77802 This slightly increases maintenance (have to track which crates need RUSTC_BOOTSTRAP) but reduces the scope of unstable features. Doesn't seem to affect runtime i.e., the binary appears to be identical (tested on 12.2 amd64).
$ sha256 rg*
SHA256 (rg-new) = 2989083ba356013dc3b8b484470fd41a9660a4cf46d8abdc2cddad5b728daf10
SHA256 (rg-old) = 2989083ba356013dc3b8b484470fd41a9660a4cf46d8abdc2cddad5b728daf10
LGTM. Should we also remove the comment about ’packed_simd_2’ since it’s now evident which crates need RUSTC_BOOTSTRAP?
A commit in branch main references this bug:
Author: Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2021-09-08 14:38:29 +0000
Commit: Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2021-09-09 16:07:41 +0000
textproc/ripgrep: limit unstable rust features after 6bebfaa8a06c
Drop stale comment as it's now evident which crates need unstable features.
Approved by: Petteri Valkonen (maintainer)
textproc/ripgrep/Makefile | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
(In reply to Petteri Valkonen from comment #1)
> Should we also remove the comment about ’packed_simd_2’ since it’s
> now evident which crates need RUSTC_BOOTSTRAP?
Done. It needed a complete rewording but I had no cycles to bother. ;)
Stabilization seems to be stalled (related bugs closed) but maybe not completely per https://github.com/rust-lang/portable-simd/issues/146