Bug 258674 - x11/elementary-terminal: Avoid linuxism
Summary: x11/elementary-terminal: Avoid linuxism
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Neel Chauhan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-22 12:17 UTC by Olivier Duchateau
Modified: 2021-09-22 12:17 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (nc)


Attachments
Fix linuxism (5.86 KB, patch)
2021-09-22 12:17 UTC, Olivier Duchateau
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2021-09-22 12:17:26 UTC
Created attachment 228119 [details]
Fix linuxism

Original author is amdmi3@ (Dmitry Marakasov) [1] and this port was deleted [2] (even if it was another name, we should adjust MOVED file).

Line: libvte-2.91.so:x11-toolkits/vte3 should be replaced by USE_GNOME= vte3

io.elementary.terminal looks for /proc, so we need linprocfs(5) enabled (see pkg-message.in file).

In src/Widgets/TerminalWidget.vala there is a command, which requires dbus (dbus-send), this utility is deprecated, we should use gdbus (from devel/glib20). Moreover it uses specific builtin bash. It is better to avoid to export this command (other shells completion are wrong).

io.elementary.terminal exposes io.elementary.terminal service (only available for this terminal, (see [3] line 23), we have better tool with procstat(1). So we can delete the 'PROMPT_COMMAND' environment variable. I wonder if 'PANTHEON_TERMINAL_ID' is still usefull. I try dbus-send (and gdbus call) commands, none work!

In file settings, we provide generic font, otherwise contains of io.elementary.terminal is ugly (at least on my xfce session with default Gtk theme)

Based on my own port [4].

[1] https://cgit.freebsd.org/ports/tree/x11/pantheon-terminal/Makefile?h=2019Q1
[2] https://cgit.freebsd.org/ports/tree/MOVED#n11572
[3] https://github.com/elementary/terminal/blob/6.0.0/src/DBus.vala#L23
[4] https://codeberg.org/olivierd/freebsd-ports-elementary/src/branch/6.0/x11/elementary-terminal