Bug 258848 - mail/exim: update 4.94.2 -> 4.95
Summary: mail/exim: update 4.94.2 -> 4.95
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-01 19:12 UTC by Kurt Jaeger
Modified: 2021-12-29 13:48 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (fluffy)


Attachments
patch (6.85 KB, patch)
2021-10-01 19:12 UTC, Kurt Jaeger
no flags Details | Diff
sendfile patch, fixes SIGSEGV using clamd via TCP (451 bytes, patch)
2021-11-13 18:21 UTC, Oliver Heesakkers
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2021-10-01 19:12:39 UTC
Created attachment 228332 [details]
patch

testbuilds look fine. testrun on 12.2-amd64 looks fine as well. We should probably wait for after Q4.
Comment 1 Dima Panov freebsd_committer freebsd_triage 2021-10-01 19:18:30 UTC
(In reply to Kurt Jaeger from comment #0)

Kurt, is this release good for u with tainted rules or it is problematic as 4.94 was before thirdparty taintwarn patches?
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2021-10-01 19:33:12 UTC
My testbox is using it in a config with TAINTWARN=off

If we want to be sure that nothing blows up, I need to do more testing 8-}
Comment 3 Dima Panov freebsd_committer freebsd_triage 2021-10-01 20:23:19 UTC
(In reply to Kurt Jaeger from comment #2)
If it possible, yes please :) tainted rules is a massive issue, I don't want to ruin everything working :)
Comment 4 Oliver Heesakkers 2021-10-10 11:55:36 UTC
Just in case you don't keep up with the exim user mailing list, I'll reference this thread here as an FYI:

https://lists.exim.org/lurker/message/20211009.222513.c3ec4c7a.en.html
Comment 5 Dima Panov freebsd_committer freebsd_triage 2021-11-13 18:03:53 UTC
*** Bug 259822 has been marked as a duplicate of this bug. ***
Comment 6 Oliver Heesakkers 2021-11-13 18:20:37 UTC
That reminds me.
After a bit of back and forth between upstream and myself a patch was created (by upstream) for this, the patched file is in GH (https://github.com/Exim/exim/blob/master/src/OS/os.c-FreeBSD). I'll attach the patch that I use myself in this PR.

I've been running Exim 4.95 SIGSEGV free ever since, but also must admit I no longer use TCP connections for clamd.
Comment 7 Oliver Heesakkers 2021-11-13 18:21:23 UTC
Created attachment 229480 [details]
sendfile patch, fixes SIGSEGV using clamd via TCP
Comment 8 Dima Panov freebsd_committer freebsd_triage 2021-11-13 18:35:21 UTC
(In reply to Oliver Heesakkers from comment #6)
Thanks, will probe it on my own hosts. 

SIGSEVs is showstoppers now :(
Comment 9 commit-hook freebsd_committer freebsd_triage 2021-12-28 19:33:49 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=99c5dc1049a23570016dcb5ac44882e408800622

commit 99c5dc1049a23570016dcb5ac44882e408800622
Author:     Dima Panov <fluffy@FreeBSD.org>
AuthorDate: 2021-12-28 19:23:16 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2021-12-28 19:23:16 +0000

    mail/exim: update to 4.95 release (+)

    Finally, Exim will be pushed to 4.95 release.
    Long wait was caused by some criticals errors in vanilla release,
    upstream fixes got a some time to come.

    * Apply sendfile patch, fixes SIGSEGV using clamd via TCP [1]
    * Convert select() to poll(), fixes crashes (SIGSEV) on FreeBSD 12.2 [2]

    PR:     258848 [1], 259822 [2]
    Sponsored by:   Netzkommune GmbH

 mail/exim/Makefile                                 |  35 +-
 mail/exim/distinfo                                 |   6 +-
 ...fig-option-allow_insecure_tainted_.patch (gone) | 230 -----
 mail/exim/files/debian/75_02-search.patch (gone)   |  39 -
 mail/exim/files/debian/75_03-dbstuff.patch (gone)  |  30 -
 mail/exim/files/debian/75_04-acl.patch (gone)      |  67 --
 mail/exim/files/debian/75_05-parse.patch (gone)    |  30 -
 mail/exim/files/debian/75_06-rda.patch (gone)      |  28 -
 .../files/debian/75_07-appendfile.patch (gone)     |  34 -
 .../exim/files/debian/75_08-autoreply.patch (gone) |  70 --
 mail/exim/files/debian/75_09-pipe.patch (gone)     |  36 -
 mail/exim/files/debian/75_10-deliver.patch (gone)  |  49 --
 .../exim/files/debian/75_11-directory.patch (gone) |  26 -
 mail/exim/files/debian/75_12-expand.patch (gone)   |  34 -
 .../files/debian/75_13-lf_sqlperform.patch (gone)  |  49 --
 .../debian/75_14-rf_get_transport.patch (gone)     |  28 -
 mail/exim/files/debian/75_15-deliver.patch (gone)  |  31 -
 mail/exim/files/debian/75_16-smtp_out.patch (gone) |  38 -
 mail/exim/files/debian/75_17-smtp.patch (gone)     |  29 -
 .../files/debian/75_18-update-doc.patch (gone)     | 154 ----
 ...and-rejectlog_name-unconditionally.patch (gone) |  42 -
 .../files/debian/75_21-tidy-log.c.patch (gone)     | 124 ---
 .../debian/75_22-Silence-compiler.patch (gone)     | 222 -----
 ...ain-_log-if-we-do-not-see-a-chance.patch (gone) | 166 ----
 .../debian/75_24-Silence-the-compiler.patch (gone) |  57 --
 ...s-for-mkdir-this-isn-t-part-of-4.9.patch (gone) |  27 -
 ...timeofday-select-per-char-for-cmdli.patch (new) | 616 ++++++++++++++
 ...ll-uses-of-select-to-poll.-Bug-2831.patch (new) | 931 +++++++++++++++++++++
 ...asic-memory-use-for-SPARC.-Bug-2838.patch (new) | 140 ++++
 mail/exim/files/patch-OS_os.c-FreeBSD (new)        |  15 +
 mail/exim/files/patch-OS_os.h-FreeBSD (gone)       |  17 -
 mail/exim/files/patch-src__EDITME                  |  46 +-
 mail/exim/options                                  |   1 -
 33 files changed, 1736 insertions(+), 1711 deletions(-)