Bug 258928 - editors/pluma: stage-qa fails (bad shebangs)
Summary: editors/pluma: stage-qa fails (bad shebangs)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome (Nobody)
URL: https://github.com/mate-desktop/pluma...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-04 14:58 UTC by John Hein
Modified: 2021-10-14 12:16 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)


Attachments
[patch] fix pluma shebangs noticed by stage-qa (1.02 KB, patch)
2021-10-04 15:03 UTC, John Hein
jcfyecrayz: maintainer-approval? (ericbsd)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2021-10-04 14:58:10 UTC
'make -C editors/pluma stage stage-qa' fails:

====> Running Q/A tests (stage-qa)
Error: '/usr/bin/sh' is an invalid shebang you need USES=shebangfix for 'libexec/pluma/pluma-bugreport.sh'
Error: '/usr/bin/sh' is an invalid shebang you need USES=shebangfix for 'share/pluma/plugins/externaltools/tools/
build'
Error: '/usr/bin/sh' is an invalid shebang you need USES=shebangfix for 'share/pluma/plugins/externaltools/tools/
open-terminal-here'
Error: '/usr/bin/sh' is an invalid shebang you need USES=shebangfix for 'share/pluma/plugins/externaltools/tools/
remove-trailing-spaces'
Error: '/usr/bin/sh' is an invalid shebang you need USES=shebangfix for 'share/pluma/plugins/externaltools/tools/
run-command'
Error: '/usr/bin/sh' is an invalid shebang you need USES=shebangfix for 'share/pluma/plugins/externaltools/tools/
search-recursive'
Comment 1 John Hein 2021-10-04 14:58:36 UTC
Committer CC'd.
Comment 2 John Hein 2021-10-04 15:03:39 UTC
Created attachment 228437 [details]
[patch] fix pluma shebangs noticed by stage-qa

The attached patch fixes the files with bad shebangs (/usr/bin/sh -> /bin/sh).
Comment 3 John Hein 2021-10-04 15:05:21 UTC
See also upstream commit / discussion: https://github.com/mate-desktop/pluma/pull/626#issuecomment-932966925
Comment 4 John Hein 2021-10-11 19:37:07 UTC
(In reply to John Hein from comment #3)
Also see https://github.com/mate-desktop/pluma/issues/640

There seems to be upstream consensus that using #!/usr/bin/sh should be reverted back to #!/bin/sh instead.   But that won't help for 1.26.0 of course.  So this patch should be applied to the freebsd port (with a commit and/or Makefile comment stating that future releases may not use /usr/bin/sh).
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-10-14 10:58:46 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=36492f88fdaf6ca6fc83eb6ba8c32f4826497eaf

commit 36492f88fdaf6ca6fc83eb6ba8c32f4826497eaf
Author:     Eric Turgeon <ericbsd@FreeBSD.org>
AuthorDate: 2021-10-14 10:53:10 +0000
Commit:     Eric Turgeon <ericbsd@FreeBSD.org>
CommitDate: 2021-10-14 10:58:01 +0000

    editors/pluma: fixed bad shebangs

    PR:             258928
    Reported by:    John Hein

 editors/pluma/Makefile | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)