Bug 258945 - [New Port] databases/imposm3 - Utility to import OpenStreetMap data into PostgreSQL
Summary: [New Port] databases/imposm3 - Utility to import OpenStreetMap data into Post...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Nuno Teixeira
URL: http://imposm.org/docs/imposm3/latest/
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-05 12:05 UTC by Darcy Buskermolen
Modified: 2023-06-03 09:58 UTC (History)
2 users (show)

See Also:


Attachments
first try at a port file (7.05 KB, application/x-shellscript)
2021-10-21 11:14 UTC, Darcy Buskermolen
no flags Details
sugested diff v0 (2.02 KB, patch)
2023-01-24 09:51 UTC, Nuno Teixeira
no flags Details | Diff
suggested diff v1 (2.05 KB, patch)
2023-01-30 05:53 UTC, Ian Wagner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darcy Buskermolen 2021-10-05 12:05:40 UTC
Update imposm to Version 0.11.1 https://github.com/omniscale/imposm3/commit/53bb80726ca9456e4a0857b38803f9ccfe8e33fd
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2021-10-08 09:23:33 UTC
misc/imposm3 does't exist in ports
Comment 2 Darcy Buskermolen 2021-10-08 12:38:37 UTC
Opps sorry, this should have been filed as a New port.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2021-10-08 15:46:08 UTC
https://docs.freebsd.org/en/books/porters-handbook/quick-porting/

You can change this PR subject name to "[NEW PORT] category/portname short description of the port" and submit a patch.

Cheers
Comment 4 Darcy Buskermolen 2021-10-21 11:14:04 UTC
Created attachment 228920 [details]
first try at a port file
Comment 5 Ian Wagner 2023-01-24 05:40:03 UTC
Is there any movement on this port? I was actually just about to submit a patch myself but Bugzilla pointed out this as a possible duplicate. 

Aside: I would suggest placing this in databases; misc is not very descriptive.
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-24 09:51:14 UTC
Created attachment 239675 [details]
sugested diff v0

- moved to databases category
- updated COMMENT as upstream short description
- updated pkg-descr as upstream long description
- defined LICENSE_FILE
- use LIB_DEPENDS as upstream recomendations
- remove gmake dependency
- use GO_MODULE method
- define Version as instructed in ${WRCSRC}/version.go
- use PORTEAXMPLES macro
- removed ${WRKDIR}/files/patch-* as don't needed

Sugestion: add an DOCS option with desired documentation (similar to EXAMPLES)

Could you do a test run?

Cheers
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-29 20:28:37 UTC
Friendly ping
Comment 8 Ian Wagner 2023-01-30 05:53:48 UTC
Created attachment 239799 [details]
suggested diff v1

Minor revisions:

- Change name to imposm3
- Add to geography category
Comment 9 Ian Wagner 2023-01-30 05:55:02 UTC
I can confirm that your patch is working, Nuno (it'd also be nice to hear from the new maintainer though.)

I've suggested two minor changes; sorry I didn't upload a proper diff before. The changes from yours are as follows:

- Change portname to imposm3 (that really is the technical name at the moment)
- Add geography to categories

Thanks!
Comment 10 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-30 09:58:07 UTC
(In reply to Ian Wagner from comment #9)

Not sure about changing name from 'imposm' to 'imposm3' since project description mentions imposm, https://github.com/omniscale/imposm3/#imposm even if project name is imposm3. But I'm ok with both choices.

I also agree to add port to 'geography' category.

Lets wait for maintainer opinion to get this committed.

Cheers
Comment 11 Ian Wagner 2023-01-30 12:30:10 UTC
Yeah, they are not even internally consistent (like the version number is 0.11.1 on GitHub but their homepage refers to it as imposm3 3.0.0a, the binaries used to be called imposm3, etc.) Agree let's wait for maintainer feedback; I could go either way. Cheers :)
Comment 12 Darcy Buskermolen 2023-05-31 10:56:01 UTC
(In reply to Ian Wagner from comment #9)
The Geography category is a best fit lets go with that
Comment 13 Darcy Buskermolen 2023-05-31 10:58:53 UTC
(In reply to Ian Wagner from comment #11)
after a bit more review and consideration, imposm3 is, in fact, the correct name as it's a rewrite of imposm2 etc. We should follow the authors' intent and guidance on this front.
Comment 14 commit-hook freebsd_committer freebsd_triage 2023-06-03 09:57:23 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ddb66bae1b1694cab21a0b52d6bd4d8f17260100

commit ddb66bae1b1694cab21a0b52d6bd4d8f17260100
Author:     Darcy <darcy@dbitech.ca>
AuthorDate: 2023-06-03 09:51:39 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-06-03 09:56:21 +0000

    databases/imposm3: New port: Utility to import OpenStreetMap data into PostgreSQL

     - Submitter becomes maintainer

    Imposm is an importer for OpenStreetMap data. It reads PBF files and
    imports the data into PostgreSQL/PostGIS. It can also automatically
    update the database with the latest changes from OSM.

    It is designed to create databases that are optimized for rendering
    (i.e. generating tiles or for WMS services).

    WWW:            http://imposm.org/docs/imposm3/latest/
    PR:             258945

 databases/Makefile                |  1 +
 databases/imposm3/Makefile (new)  | 31 +++++++++++++++++++++++++++++++
 databases/imposm3/distinfo (new)  |  5 +++++
 databases/imposm3/pkg-descr (new) |  6 ++++++
 4 files changed, 43 insertions(+)
Comment 15 Nuno Teixeira freebsd_committer freebsd_triage 2023-06-03 09:58:36 UTC
Committed, thanks!