Bug 258997 - devel/electron12: Fails to build with DIST option enabled: sandbox/linux/suid/sandbox.c:12:10: fatal error: 'asm/unistd.h' file not found
Summary: devel/electron12: Fails to build with DIST option enabled: sandbox/linux/suid...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Hiroki Tagato
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2021-10-08 02:16 UTC by Wes Morgan
Modified: 2021-11-15 05:40 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (tagattie)

Attachments
Partial build log (196.50 KB, text/plain)
2021-10-08 02:16 UTC, Wes Morgan 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wes Morgan 2021-10-08 02:16:18 UTC 
Created attachment 228507 [details]
Partial build log

As mentioned in 257378, electron12 fails due to a missing linux-specific header.

Attached partial build log of electron12 on amd64 13-stable.

../../sandbox/linux/suid/sandbox.c:12:10: fatal error: 'asm/unistd.h' file not found
#include <asm/unistd.h>
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-10-08 02:23:39 UTC 
Thank you for the report Wes.

Could you

 - include as an attachment pkg version -v output, and
 - test/confirm whether the issue is reproducible with default OPTIONS (make rmconfig to revert to the defaults). 

If the issue is not reproducible, please isolate which minimum set of OPTIONS are required to introduce the build failure
Comment 2 Wes Morgan 2021-10-08 03:15:27 UTC 
To be clear, you mean from the build machine, correct?
Comment 3 Wes Morgan 2021-10-08 16:52:51 UTC 
Checked with default options and they work. The DIST option seems to cause the failure.
Comment 4 commit-hook freebsd_committer freebsd_triage 2021-11-15 05:38:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1939382c88ed3a84d1872643ca958ff41ac214a0

commit 1939382c88ed3a84d1872643ca958ff41ac214a0
Author:     Hiroki Tagato <tagattie@FreeBSD.org>
AuthorDate: 2021-11-15 05:34:37 +0000
Commit:     Hiroki Tagato <tagattie@FreeBSD.org>
CommitDate: 2021-11-15 05:37:04 +0000

    devel/electron12: fix build with DIST option enabled

    PR:             258997
    Reported by:    Wes Morgan <morganw@gmail.com>

 devel/electron12/files/patch-electron_BUILD.gn | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
Comment 5 Hiroki Tagato freebsd_committer freebsd_triage 2021-11-15 05:40:16 UTC 
Thanks for the bug report.

I have committed a fix. Now it should build with DIST option enabled.