Bug 259094 - sysutils/htop: plug memory leak when displaying Disk I/O in the header area
Summary: sysutils/htop: plug memory leak when displaying Disk I/O in the header area
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on: 259406
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-12 09:13 UTC by Trond Endrestøl
Modified: 2021-10-25 13:31 UTC (History)
5 users (show)

See Also:
gaod: maintainer-feedback+

Attachments
Patch for freebsd/Platform.c turning the local info variable to a static, local variable (356 bytes, patch)
2021-10-12 09:14 UTC, Trond Endrestøl 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2021-10-12 09:13:27 UTC 
Without this patch, htop leaks 4 bytes of memory for each update.
The very same bug is fixed in the development version of htop.
Comment 1 Trond Endrestøl 2021-10-12 09:14:27 UTC 
Created attachment 228620 [details]
Patch for freebsd/Platform.c turning the local info variable to a static, local variable
Comment 3 Hung-Yi Chen 2021-10-20 21:23:18 UTC 
The patch is contained within 3.1.1.

Would you mind that I just update the port to 3.1.1?
Comment 4 Trond Endrestøl 2021-10-21 08:11:12 UTC 
(In reply to Hung-Yi Chen from comment #3)
Upgrading to 3.1.1 is probably the best thing to do.
Make it so. (Sorry, I couldn't resist.)
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2021-10-25 08:30:13 UTC 
Hello,

I've just committed htop 3.1.1 in https://cgit.freebsd.org/ports/commit/?id=4c66dde9668524e734760c634c6c1090d16c7887

Could this PR be closed?

Cheers
Comment 6 Trond Endrestøl 2021-10-25 13:31:02 UTC 
Fixed by upgrading the port to 3.1.1.