Hi, I was noticing that after an upgrade from 3003.3_1 to 3004 that running high states shows some warnings about the version of pyzmq installed: --- Traceback (most recent call last): File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 568, in _build_master ws.require(__requires__) File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 886, in require needed = self.resolve(parse_requirements(requirements)) File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 777, in resolve raise VersionConflict(dist, req).with_context(dependent_req) pkg_resources.ContextualVersionConflict: (pyzmq 22.3.0 (/usr/local/lib/python3.8/site-packages), Requirement.parse('pyzmq<22.0.0,>=17.0.0'), {'salt'}) --- #> pkg info | grep pyz py38-pyzmq-22.3.0 Python bindings for ZeroMQ --- The states seem to run fine, so I am not sure if this is just a neglected requirements that was missed, or if there are actual problems with 22.3.0 that is used in 2021Q4. Anyway, thanks in advance! o/
This also breaks salt_api if you use a cherrypy webgui like SaltGUI --------------------------------------------------------------- 2021-10-25 15:28:48,994 [salt.loader.lazy :787 ][ERROR ][7065] Failed to import netapi rest_cherrypy, this is due most likely to a syntax error: Traceback (most recent call last): File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 568, in _build_master ws.require(__requires__) File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 886, in require needed = self.resolve(parse_requirements(requirements)) File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 777, in resolve raise VersionConflict(dist, req).with_context(dependent_req) pkg_resources.ContextualVersionConflict: (pyzmq 22.3.0 (/usr/local/lib/python3.8/site-packages), Requirement.parse('pyzmq<22.0.0,>=17.0.0'), {'salt'}) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/usr/local/lib/python3.8/site-packages/salt/loader/lazy.py", line 745, in _load_module mod = spec.loader.load_module() File "<frozen importlib._bootstrap_external>", line 522, in _check_name_wrapper File "<frozen importlib._bootstrap_external>", line 1022, in load_module File "<frozen importlib._bootstrap_external>", line 847, in load_module File "<frozen importlib._bootstrap>", line 265, in _load_module_shim File "<frozen importlib._bootstrap>", line 702, in _load File "<frozen importlib._bootstrap>", line 671, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 843, in exec_module File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed File "/usr/local/lib/python3.8/site-packages/salt/netapi/rest_cherrypy/__init__.py", line 16, in <module> import cherrypy File "/usr/local/lib/python3.8/site-packages/cherrypy/__init__.py", line 60, in <module> import pkg_resources File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 3243, in <module> def _initialize_master_working_set(): File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 3226, in _call_aside f(*args, **kwargs) File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 3255, in _initialize_master_working_set working_set = WorkingSet._build_master() File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 570, in _build_master return cls._build_from_requirements(__requires__) File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 583, in _build_from_requirements dists = ws.resolve(reqs, Environment()) File "/usr/local/lib/python3.8/site-packages/pkg_resources/__init__.py", line 772, in resolve raise DistributionNotFound(req, requirers) pkg_resources.DistributionNotFound: The 'pyzmq<22.0.0,>=17.0.0' distribution was not found and is required by salt ---------------------------------------------------------------
Also breaks any "pip.installed" states.
Here is the commit in salt which introduced this new limitation: https://github.com/saltstack/salt/commit/070597e525bb7d56ffadede1aede325dfb1b73a4 Its really not clear what bug this was fixing.
Is latest (ports head) affected in the same, similar of different way? Current Port versions would indicate yes Do (upstream) tests pass if '<22.0.0' is removed (patched out) of the version-spec ? Worse case we'll need pyzmq21.
I reckon that since the change in salt doesn't fix any known bug and everything was working fine before this change, the simplest solution is to patch out the new pyzmq version requirement. Could we PLEASE have a new salt-latest port to track the latest buggy salt release instead of advancing this port to introduce major new bugs every 6 months?
We should ensure (in addition to a -dev port if thats valuable for users) that complete and extensive QA is run as well. TEST_DEPENDS and a test target would go a long way to this.
I noticed that the patch was applied to the 2021Q4 branch, and so far, everything seems just fine here. I can't speak for the others here, of course. Thanks!
krion@ committed ports 13f3619de8bd @Kirill Is head/latest also affected or is this issue now resolved? If thelatter, please self-assign and close, thanks!
@Kubilay we're investigating it now at upstream, it will be fixed next week I guess, will let you know and update this PR accordingly.
Fixed in upstream, so I'll close this report.
(In reply to Kirill Ponomarev from comment #10) If the port/package is currently affected, is this actually resolved?
And could you point us to upstream (issue, pr, commit) references
This was resolved for me by this patch: https://cgit.freebsd.org/ports/commit/?id=ddffa24d1a494a4354d84b553f08f493e0220c11 Whether salt upstream fixes it for the next release in six months is irrelevant to the situation today.
^Triage: Assign to committer that resolved (PR: not referenced)
Does anyone know how long it generally takes for a package to be updated after a patch like this is done? I'm trying to decide if it's worth my time and resources to set up poudriere or not.
(In reply to Michele Possamai from comment #15) Usually up to 48 hours (to complete, not start), all else being equal on the official builders