Bug 259333 - security/vaultwarden Update to 1.23.0
Summary: security/vaultwarden Update to 1.23.0
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Michael Reifenberger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-21 09:11 UTC by Adrien
Modified: 2021-11-12 19:39 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (mr)


Attachments
git diff vaultwarden (69.49 KB, patch)
2021-10-21 09:11 UTC, Adrien
no flags Details | Diff
git diff for security/vaultwarden (68.96 KB, patch)
2021-10-22 10:05 UTC, Bernard Spil
brnrd: maintainer-approval? (mr)
Details | Diff
git diff for security/vaultwarden (76.38 KB, patch)
2021-10-28 19:02 UTC, Adrien
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien 2021-10-21 09:11:04 UTC
Created attachment 228914 [details]
git diff vaultwarden

Hi,

Another update have just dropped :). 
I've attached the patch below.

BR,
Adrien
Comment 1 Bernard Spil freebsd_committer 2021-10-22 10:05:41 UTC
Created attachment 228940 [details]
git diff for security/vaultwarden

Removes PORTREVISION
Removes duplicate rc.d/vaultwarden
Comment 2 Adrien 2021-10-28 19:02:22 UTC
Created attachment 229104 [details]
git diff for security/vaultwarden

Hey,

Updated to web-vault 2.24.0
Integrated changes from Bernard  (thanks :) )

BR,
Adrien
Comment 3 Adrien 2021-10-28 19:02:53 UTC
(In reply to Adrien from comment #2)
*2.24.1
Comment 4 commit-hook freebsd_committer 2021-10-30 17:17:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=847479c553f7f319a11144719dea57bc9a76f2f6

commit 847479c553f7f319a11144719dea57bc9a76f2f6
Author:     Michael Reifenberger <mr@FreeBSD.org>
AuthorDate: 2021-10-30 17:15:45 +0000
Commit:     Michael Reifenberger <mr@FreeBSD.org>
CommitDate: 2021-10-30 17:15:45 +0000

    security/vaultwarden: Update to 1.23.0

    PR:             259333
    Reported by:    Adrien

 security/vaultwarden/Makefile  | 202 ++++++++++----------
 security/vaultwarden/distinfo  | 414 ++++++++++++++++++++---------------------
 security/vaultwarden/pkg-plist |  76 ++++----
 3 files changed, 348 insertions(+), 344 deletions(-)
Comment 5 Ralf van der Enden 2021-10-31 02:18:12 UTC
Hi,

vaultwarden 1.23 doesn't build since it requires rust 1.57. Ports have 1.56, so it throws an error:

===>  Building for vaultwarden-1.23.0_4
error: package `vaultwarden v1.0.0 (/wrkdirs/usr/ports/security/vaultwarden/work/vaultwarden-1.23.0)` cannot be built because it requires rustc 1.57 or newer, while the currently active rustc version is 1.56.0
*** Error code 101

On another note, the port was committed with the PORTREVISION still set to 4
Comment 6 Adrien 2021-11-12 17:54:43 UTC
(In reply to Ralf van der Enden from comment #5)
yeah it seems :(, I tried to add a BUILD_DEPEND to rust-nightly but can't make it work...
Comment 7 Michael Reifenberger freebsd_committer 2021-11-12 18:07:50 UTC
Hi,
I havn't found a way to use rust-nightly too..
Comment 8 Ralf van der Enden 2021-11-12 19:20:14 UTC
You can patch the Cargo.toml and set the required rust version to 1.56

It does compile and seems to work fine, but I'm not sure if issues might arise.
Comment 9 Adrien 2021-11-12 19:39:24 UTC
(In reply to Ralf van der Enden from comment #8)
I asked the dev about that on their matrix channel on 4th November. They said that it wouldn't work because of the rocket version they use. What I don't understand is that rocket didn't change between 1.22.2 and 1.23.0. I guess doing this would be okay...