Bug 259339 - multimedia/flvmeta: Update to 1.2.2
Summary: multimedia/flvmeta: Update to 1.2.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL: https://github.com/noirotm/flvmeta/re...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-21 12:51 UTC by Gian-Simon Purkert
Modified: 2022-11-13 19:23 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (earl)


Attachments
Update to 1.1.0 (1.04 KB, patch)
2021-10-21 12:51 UTC, Gian-Simon Purkert
no flags Details | Diff
Update to 1.2.2 (1.35 KB, patch)
2022-09-30 10:29 UTC, Gian-Simon Purkert
no flags Details | Diff
Update to 1.2.2 + corrected DISTVERSION (1.39 KB, patch)
2022-09-30 12:08 UTC, Gian-Simon Purkert
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gian-Simon Purkert 2021-10-21 12:51:57 UTC
Created attachment 228923 [details]
Update to 1.1.0

* Added proper command line handling and help. * Added the possibility to overwrite the input file when the output file is not specified or when both files are physically the same. * Added support for CMake builds in addition to autotools. It is now the official way to build flvmeta on Windows. * Added metadata and full file dumping, integrating former flvdump functionality into flvmeta. * Added support for XML, YAML, and JSON formats for dumping. * Added XML schemas describing the various formats used by flvmeta. * Added a file checking feature. * Added the possibility to print output file metadata after a successful update using one of the supported formats. * Added a feature to insert custom metadata strings while updating. * Added an option to disable insertion of the onLastSecond event. * Added an option to preserve existing metadata tags if possible. * Added an option to fix invalid tags while updating (this is a highly experimental feature, should be used with caution) * Added an option to ignore invalid tags as much as possible instead of exiting at the first error detected. * Added an option to reset the file timestamps in order to correctly start at zero, for example if the file has been incorrectly split by buggy tools. * Added an option to display informative messages while processing (not quite exhaustive for the moment). * Changed keyframe index generation so only the first keyframe for a given timestamp will be indexed. This behaviour can be overriden with the --all-keyframes/-k option.

https://code.google.com/archive/p/flvmeta/wikis/ChangeLog.wiki
Comment 1 Gian-Simon Purkert 2021-12-20 10:16:05 UTC
Ping
Comment 2 Hiroki Tagato freebsd_committer freebsd_triage 2021-12-22 06:29:35 UTC
Configure phase fails with the following error:

=======================<phase: configure      >============================
===>   flvmeta-1.1.0 depends on package: autoconf>=2.69 - found
===>   flvmeta-1.1.0 depends on package: automake>=1.16.1 - found
===>  Configuring for flvmeta-1.1.0
configure.ac:13: installing './compile'
configure.ac:9: installing './install-sh'
configure.ac:9: installing './missing'
src/Makefile.am: installing './depcomp'
parallel-tests: installing './test-driver'
configure: loading site script /usr/ports/Templates/config.site
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... (cached) /bin/mkdir -p
checking for gawk... (cached) /usr/bin/awk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for gcc... cc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether cc accepts -g... yes
checking for cc option to accept ISO C89... none needed
checking whether cc understands -c and -o together... yes
checking whether make supports the include directive... yes (GNU style)
checking dependency style of cc... gcc3
checking for ranlib... ranlib
checking for pandoc... no
./configure: 4369: Syntax error: word unexpected (expecting ")")
===>  Script "configure" failed unexpectedly.
Please report the problem to earl@eeg3.net [maintainer] and attach the
"/wrkdirs/usr/ports/multimedia/flvmeta/work/flvmeta-1.1.0/config.log" including
the output of the failure of your make command. Also, it might be a good idea
to provide an overview of all packages installed on your system (e.g. a
/usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

Stop.
make: stopped in /usr/ports/multimedia/flvmeta

Could you look into this issue?
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2021-12-22 07:14:02 UTC
Why are bumping it do an old release?
https://github.com/noirotm/flvmeta/tags

If we're to follow Porters Handbook DISTVERSIONPREFIX should be defined before DISTVERSION (which replaces PORTVERSION).
Comment 4 Hiroki Tagato freebsd_committer freebsd_triage 2021-12-22 08:32:31 UTC
(In reply to Daniel Engberg from comment #3)

Thanks Daniel for pointing out the new upstream URL. It appears it has v1.2.2 as the latest version.

@reporter and @maintainer, can you take time to update the port to the latest one?
Comment 5 Gian-Simon Purkert 2022-09-30 10:29:41 UTC
Created attachment 236965 [details]
Update to 1.2.2

Update to 1.2.2 and patch+ for compilation on FreeBSD:

https://github.com/noirotm/flvmeta/commit/2cc65a626ba30339ddc2d8fb6c36a69ecb32bd96
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2022-09-30 11:18:14 UTC
This is incorrect as 62e30a7  doesn't not correspond to the release tag. You should pull in additional patching using either files/patch-.... or PATCH_SITES and PATCHFILES (use full git hash)

In this case I'd advise you to read the Porters Handbook ( https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github )
Example 16 or possible 18 are what you're looking for

Best regards,
Daniel
Comment 7 Gian-Simon Purkert 2022-09-30 11:55:39 UTC
(In reply to Daniel Engberg from comment #6)
Thanks Daniel,

I think Example 16 is the way to go until a new release.
Comment 8 Gian-Simon Purkert 2022-09-30 12:08:45 UTC
Created attachment 236968 [details]
Update to 1.2.2 + corrected DISTVERSION
Comment 9 Gian-Simon Purkert 2022-10-02 08:40:19 UTC
Ping
Comment 10 Gian-Simon Purkert 2022-11-09 21:53:00 UTC
Any news?
Comment 11 Daniel Engberg freebsd_committer freebsd_triage 2022-11-09 22:56:40 UTC
It's in queue, my build box is busy with other things atm
Comment 12 Gian-Simon Purkert 2022-11-11 08:47:50 UTC
(In reply to Daniel Engberg from comment #11)

Nice, thanks.
Comment 13 commit-hook freebsd_committer freebsd_triage 2022-11-13 19:23:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3346ed87cd954563eeb5e2b5e2ef4300bef069c3

commit 3346ed87cd954563eeb5e2b5e2ef4300bef069c3
Author:     Gian-Simon Purkert <gspurki@gmail.com>
AuthorDate: 2022-11-13 19:05:41 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-11-13 19:05:45 +0000

    multimedia/flvmeta: Update to latest commit

    Use latest commit as development seems to have slowed down upstream
    and contains multiple build fixes

    Changelog: https://github.com/noirotm/flvmeta/releases/tag/v1.2.2

    Some addtional changes to patch:
    - Use libyaml from ports instead of bundled version
    - Use a pre-rendered man page instead of pulling in pandoc

    PR:             259339
    Approved by:    maintainer timeout (1+ year)

 multimedia/flvmeta/Makefile                        |  25 +-
 multimedia/flvmeta/distinfo                        |   6 +-
 multimedia/flvmeta/files/patch-man_flvmeta.1 (new) | 461 +++++++++++++++++++++
 3 files changed, 482 insertions(+), 10 deletions(-)
Comment 14 Daniel Engberg freebsd_committer freebsd_triage 2022-11-13 19:23:30 UTC
Committed, sorry for the wait