Bug 259344 - HEALTH column misaligned in 'zpool list -v' command
Summary: HEALTH column misaligned in 'zpool list -v' command
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 13.0-RELEASE
Hardware: Any Any
: --- Affects Many People
Assignee: Graham Perrin
URL: https://github.com/freebsd/freebsd-sr...
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-21 16:13 UTC by Slawomir Wojciech Wojtczak
Modified: 2022-12-05 03:18 UTC (History)
2 users (show)

See Also:

Attachments
A non-wrapped view of some of the text from comment 0 (976 bytes, text/plain)
2022-12-05 03:06 UTC, Graham Perrin 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Slawomir Wojciech Wojtczak 2021-10-21 16:13:35 UTC 
Hi,

this is on 13.0-RELEASE system.

% uname -a
FreeBSD w520.local 13.0-RELEASE FreeBSD 13.0-RELEASE #0 releng/13.0-n244733-ea31abc261f: Fri Apr  9 04:24:09 UTC 2021     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC  amd64

The HEALTH column is misaligned and also shouldn't the ALTROOT have the '-' as line above?

% zpool list -vLP
NAME                SIZE  ALLOC   FREE  CKPOINT  EXPANDSZ   FRAG    CAP  DEDUP    HEALTH  ALTROOT
savio              3.62T  3.27T   365G        -         -    22%    90%  1.10x    ONLINE  -
  /dev/ada0p1.eli  3.62T  3.27T   365G        -         -    22%  90.2%      -  ONLINE  
zroot               118G  28.3G  89.7G        -         -    37%    23%  1.00x    ONLINE  -
  /dev/ada1p4.eli   118G  28.3G  89.7G        -         -    37%  24.0%      -  ONLINE  

% zpool list -gv 
NAME                    SIZE  ALLOC   FREE  CKPOINT  EXPANDSZ   FRAG    CAP  DEDUP    HEALTH  ALTROOT
savio                  3.62T  3.27T   365G        -         -    22%    90%  1.10x    ONLINE  -
  2304354592570690003  3.62T  3.27T   365G        -         -    22%  90.2%      -  ONLINE  
zroot                   118G  28.3G  89.7G        -         -    37%    23%  1.00x    ONLINE  -
  8265864934020187207   118G  28.3G  89.7G        -         -    37%  24.0%      -  ONLINE  


Regards.
Comment 1 Yuri 2021-10-21 16:57:07 UTC 
This should be fixed https://github.com/openzfs/zfs/pull/11899, merged to main, and likely stable/13?
Comment 2 Slawomir Wojciech Wojtczak 2021-10-21 17:11:27 UTC 
(In reply to Yuri from comment #1)

Ok, should I close this bug now then?

As it seems it will be fixed in 13-STABLE?
Comment 3 Graham Perrin freebsd_committer freebsd_triage 2022-12-05 03:06:35 UTC 
Created attachment 238524 [details]
A non-wrapped view of some of the text from comment 0

Re: comment 0

Output from    zpool list -vLP    was too wide for Bugzilla.
Comment 4 Graham Perrin freebsd_committer freebsd_triage 2022-12-05 03:18:10 UTC 
Re: comment #1, comment #2, comment #3

<https://github.com/freebsd/freebsd-src/commit/96904d879cc0a8ec3485806150a7e0311aa907bd> in main. 

<https://github.com/freebsd/freebsd-src/commit/7bf3959601b9f0d68a5c870994121765ef05ce35> in releng/13.1 and stable/13. 

Comments added to both commits, with reference to this bug report. 

Output from    zpool list -vLP    looks good to me in FreeBSD 14.0-CURRENT (I'll not attempt to paste it here). 

If not good in 13.1-RELEASE-p5, please reopen with an attachment. 

Thanks.