Bug 259359 - update java/intellij to 2021.2.3
Summary: update java/intellij to 2021.2.3
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Boris Samorodov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-22 17:50 UTC by a52ca063
Modified: 2021-11-13 12:23 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (bsam)


Attachments
updated port files (10.68 KB, application/x-xz)
2021-10-22 17:50 UTC, a52ca063
no flags Details
git diff patch (144.40 KB, patch)
2021-10-27 21:24 UTC, a52ca063
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description a52ca063 2021-10-22 17:50:27 UTC
Created attachment 228947 [details]
updated port files
Comment 1 a52ca063 2021-10-22 17:53:05 UTC
I updated the existing port from 2020.2.3 to 2021.2.3 and ran it locally.
Comment 2 a52ca063 2021-10-27 21:24:48 UTC
Created attachment 229084 [details]
git diff patch

diff of port
Comment 3 James Wright 2021-11-13 05:11:07 UTC
Tested patch on FreeBSD 12.3-STABLE (built 2021-11-01);

1) Patch may have inadvertently removed recently added CPE info see;
https://cgit.freebsd.org/ports/commit/java/intellij/Makefile?id=70f6a3fd1b1c356e6144c8303406fa91359c284d

2) % portlint -A  
WARN: Makefile: [44]: use tab (not space) to make indentation

Hoping we can get this updated version (2021.2.3) into ports soon as the current version (2020.2.3) doesn't support builds using JDK 17 :-(
Comment 4 James Wright 2021-11-13 05:28:22 UTC
Not sure if it's obvious or not, but IntelliJ 2021.2.3 failed to start for me because I had JAVA_HOME set to the JDK 17 (/usr/local/openjdk17), switching JAVA_HOME back to JDK 11 (/usr/local/openjdk11) worked fine!
Comment 5 James Wright 2021-11-13 05:36:32 UTC
Note: Just found that I can keep my as JAVA_HOME=/usr/local/openjdk17 and still run IntelliJ using JDK 11 by setting the following env var: 
IDEA_JDK=/usr/local/openjdk11
Comment 6 a52ca063 2021-11-13 12:09:09 UTC
Hi - as this is my first patch, I need some guidance.

Were you making those changes?  Going forward, once I see the changes you've done, I can continue to incorporate those in future updates.  I hope to monitor the website for updates and publish patches more frequently.
Comment 7 James Wright 2021-11-13 12:23:42 UTC
(In reply to a52ca063 from comment #6)

I haven't made any changes, just providing some feedback for your patch regarding a couple of minor things I noticed! :-) Hopefully the maintainer of this port can take a peek also and provide some additional guidance.