Bug 259517 - wpa/hostapd fails to build when WITHOUT_CRYPT is set
Summary: wpa/hostapd fails to build when WITHOUT_CRYPT is set
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-28 22:42 UTC by Ed Maste
Modified: 2021-11-22 18:20 UTC (History)
1 user (show)

See Also:


Attachments
Disable PASN when WITHOUT_CRYPT (601 bytes, patch)
2021-10-28 23:51 UTC, Cy Schubert
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2021-10-28 22:42:04 UTC
From https://cirrus-ci.com/task/4935313328963584?logs=main#L759,

--- all_subdir_usr.sbin/wpa/hostapd ---
ld.lld: error: undefined symbol: crypto_ecdh_deinit
>>> referenced by sta_info.c:168 (/tmp/cirrus-ci-build/contrib/wpa//src/ap/sta_info.c:168)
>>>               sta_info.pieo:(ap_free_sta_pasn) in archive /usr/obj/tmp/cirrus-ci-build/amd64.amd64/usr.sbin/wpa/src/ap/libwpaap_pie.a
ld.lld: error: undefined symbol: tls_prf_sha256
>>> referenced by tlsv1_common.c:326 (/tmp/cirrus-ci-build/contrib/wpa//src/tls/tlsv1_common.c:326)
>>>               tlsv1_common.pieo:(tls_prf) in archive /usr/obj/tmp/cirrus-ci-build/amd64.amd64/usr.sbin/wpa/src/tls/libwpatls_pie.a

At commit a901f2af587f9cb068e2fca6b62f324bdde471d8
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2021-10-28 23:09:41 UTC
Thanks for the PR. This is due to CONFIG_PASN. I'll work on with/without to ensure no other fallout.
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2021-10-28 23:51:34 UTC
Created attachment 229109 [details]
Disable PASN when WITHOUT_CRYPT

This patch disables PASN when a user uses WITHOUT_CRYPT in src.conf. I briefly tested it here.
Comment 3 Ed Maste freebsd_committer freebsd_triage 2021-10-29 00:24:10 UTC
(In reply to Cy Schubert from comment #2)
Patch looks reasonable to me thanks
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2021-10-29 02:36:20 UTC
Thanks for testing.
Comment 5 commit-hook freebsd_committer freebsd_triage 2021-10-29 02:40:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=a30e8044aa4753858c189f3384dae2b2f25a150b

commit a30e8044aa4753858c189f3384dae2b2f25a150b
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2021-10-28 23:55:48 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2021-10-29 02:38:12 +0000

    wpa: Fix WITHOUT_CRYPT build

    PASN requires CRYPT and when built WITHOUT_CRYPT buildworld
    fails. Only enable PASN when MK_CRYPT is enabled (default).

    PR:             259517
    Reported by:    emaste
    Fixes:          c1d255d3ffdbe447de3ab875bf4e7d7accc5bfc5
    MFC after:      1 week

 usr.sbin/wpa/Makefile.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Comment 6 commit-hook freebsd_committer freebsd_triage 2021-11-04 18:32:43 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=ef1134110e80fe31792d01758b055a4bbec7de69

commit ef1134110e80fe31792d01758b055a4bbec7de69
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2021-10-28 23:55:48 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2021-11-04 18:30:25 +0000

    wpa: Fix WITHOUT_CRYPT build

    PASN requires CRYPT and when built WITHOUT_CRYPT buildworld
    fails. Only enable PASN when MK_CRYPT is enabled (default).

    PR:             259517
    Reported by:    emaste
    Fixes:          c1d255d3ffdbe447de3ab875bf4e7d7accc5bfc5

    (cherry picked from commit a30e8044aa4753858c189f3384dae2b2f25a150b)

 usr.sbin/wpa/Makefile.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Comment 7 Cy Schubert freebsd_committer freebsd_triage 2021-11-08 17:36:27 UTC
Committed/fixed.
Comment 8 commit-hook freebsd_committer freebsd_triage 2021-11-12 03:25:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=ba5de3c2b3b84fd547ddcc0e678a013e5df87db1

commit ba5de3c2b3b84fd547ddcc0e678a013e5df87db1
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2021-11-09 22:52:44 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2021-11-12 03:03:05 +0000

    wpa: Fix WITHOUT_OPENSSL build

    PR:             259517
    Reported by:    emaste, FreeBSD Build Option Survey
                    https://callfortesting.org/results/bos-2021-11-04/
    Fixes:          c1d255d3ffdbe447de3ab875bf4e7d7accc5bfc5
    MFC after:      1 week

 usr.sbin/wpa/Makefile.inc            | 5 ++++-
 usr.sbin/wpa/src/tls/Makefile        | 9 +++++----
 usr.sbin/wpa/wpa_supplicant/Makefile | 5 ++++-
 3 files changed, 13 insertions(+), 6 deletions(-)
Comment 9 commit-hook freebsd_committer freebsd_triage 2021-11-21 01:32:26 UTC
A commit in branch stable/13 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=c2ab6e36ec1d5eac86fea8dbe3b5ebf2300f6f76

commit c2ab6e36ec1d5eac86fea8dbe3b5ebf2300f6f76
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2021-11-09 22:52:44 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2021-11-21 01:30:49 +0000

    wpa: Fix WITHOUT_OPENSSL build

    PR:             259517
    Reported by:    emaste, FreeBSD Build Option Survey
                    https://callfortesting.org/results/bos-2021-11-04/
    Fixes:          c1d255d3ffdbe447de3ab875bf4e7d7accc5bfc5

    (cherry picked from commit ba5de3c2b3b84fd547ddcc0e678a013e5df87db1)

 usr.sbin/wpa/Makefile.inc            | 5 ++++-
 usr.sbin/wpa/src/tls/Makefile        | 9 +++++----
 usr.sbin/wpa/wpa_supplicant/Makefile | 5 ++++-
 3 files changed, 13 insertions(+), 6 deletions(-)
Comment 10 commit-hook freebsd_committer freebsd_triage 2021-11-22 18:20:27 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=4e67a8cc1c3dcb2cd27c6dc8c254d62a5ef0d509

commit 4e67a8cc1c3dcb2cd27c6dc8c254d62a5ef0d509
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2021-11-09 22:52:44 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2021-11-22 18:19:32 +0000

    wpa: Fix WITHOUT_OPENSSL build

    PR:             259517
    Reported by:    emaste, FreeBSD Build Option Survey
                    https://callfortesting.org/results/bos-2021-11-04/
    Fixes:          c1d255d3ffdbe447de3ab875bf4e7d7accc5bfc5

    (cherry picked from commit ba5de3c2b3b84fd547ddcc0e678a013e5df87db1)

 usr.sbin/wpa/Makefile.inc            | 5 ++++-
 usr.sbin/wpa/src/tls/Makefile        | 9 +++++----
 usr.sbin/wpa/wpa_supplicant/Makefile | 5 ++++-
 3 files changed, 13 insertions(+), 6 deletions(-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2021-11-22 18:20:28 UTC
A commit in branch stable/12 references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=d8b607c5a9a36fbac6ee4e97314869a7f5306832

commit d8b607c5a9a36fbac6ee4e97314869a7f5306832
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2021-10-28 23:55:48 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2021-11-22 18:19:31 +0000

    wpa: Fix WITHOUT_CRYPT build

    PASN requires CRYPT and when built WITHOUT_CRYPT buildworld
    fails. Only enable PASN when MK_CRYPT is enabled (default).

    PR:             259517
    Reported by:    emaste
    Fixes:          c1d255d3ffdbe447de3ab875bf4e7d7accc5bfc5

    (cherry picked from commit a30e8044aa4753858c189f3384dae2b2f25a150b)

 usr.sbin/wpa/Makefile.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)