Bug 259945 - mail/fetchmail: update to 6.4.24 and block LibreSSL (also updates mail/fetchmailconf)
Summary: mail/fetchmail: update to 6.4.24 and block LibreSSL (also updates mail/fetchm...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords: patch, patch-ready
Depends on: 259214
Blocks:
  Show dependency treegraph
 
Reported: 2021-11-20 10:21 UTC by Matthias Andree
Modified: 2021-11-20 23:00 UTC (History)
1 user (show)

See Also:
chalpin: maintainer-feedback+


Attachments
git patch, see inside (7.05 KB, patch)
2021-11-20 10:24 UTC, Matthias Andree
chalpin: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer 2021-11-20 10:21:02 UTC
I will upload a proposed patch (Git formatted) in a minute after recording this PR#.
Comment 1 Matthias Andree freebsd_committer 2021-11-20 10:24:16 UTC
Created attachment 229605 [details]
git patch, see inside

proposed patch update to fetchmail 6.4.24, see inside patch for details
Comment 2 Matthias Andree freebsd_committer 2021-11-20 10:27:43 UTC
Note this is not a new situation, see f. i. COPYING as of 6.4.21 or 6.2.5 (the last version that was released by Eric S. Raymond):

https://gitlab.com/fetchmail/fetchmail/-/blob/RELEASE_6-4-21/COPYING#L59
https://gitlab.com/fetchmail/fetchmail/-/blob/RELEASE_6-2-5/COPYING#L20
Comment 3 Matthias Andree freebsd_committer 2021-11-20 20:05:06 UTC
Note I am currently preparing a fetchmail 6.4.25 release that really blocks out libressl and fixes the Let's Encrypt workaround for OpenSSL 1.0.2 (I believe it irrelevant for FreeBSD as all base versions should have OpenSSL 1.1.1 these days), and it will also support wolfSSL if someone is into a GPLv2+ licensed port without the OpenSSL library hassle.
Comment 4 Corey Halpin 2021-11-20 22:34:02 UTC
Comment on attachment 229605 [details]
git patch, see inside

Looks good to me, passes `poudriere testport`, built package works in my testing.

Could a comment be added below IGNORE_SSL_REASON saying something like:
# FSF asserts that a clause 2b exception is required even for dynamically linked binaries. See https://www.gnu.org/licenses/gpl-faq.en.html#GPLStaticVsDynamic 

I was aware of the license incompatibility, but had incorrectly thought that it would only be a problem if someone were to distribute `fetchmail` binaries that were statically linked with LibreSSL.
Comment 5 commit-hook freebsd_committer 2021-11-20 22:46:57 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=30e97245f9dd9ddef1bffd874a9035a6fe9b6817

commit 30e97245f9dd9ddef1bffd874a9035a6fe9b6817
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2021-11-20 10:19:22 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2021-11-20 22:45:48 +0000

    mail/fetchmail: update to 6.4.24 and block LibreSSL.

    fetchmail cannot legally be linked with LibreSSL,
    because there is no GPLv2 clause 2b exemption for
    LibreSSL, only for OpenSSL.

    Correct LICENSE and remove LICENSE_COMB.
    Remove LibreSSL patch.

    Add FSF comment suggested by Corey Halpin in PR.

    Related to:
    PR:             259214

    Update:
    PR:             259945
    MFH:            2021Q4

    Approved by:    chalpin@cs.wisc.edu (maintainer)

 mail/fetchmail/Makefile                    | 78 ++++++++++++++++++------------
 mail/fetchmail/distinfo                    |  6 +--
 mail/fetchmail/files/patch-LibreSSL (gone) | 14 ------
 mail/fetchmailconf/Makefile                | 21 ++++----
 4 files changed, 60 insertions(+), 59 deletions(-)
Comment 6 Matthias Andree freebsd_committer 2021-11-20 22:49:21 UTC
Thanks for the tests, and your suggestion and pointer to the FSF gnu.org statement.  Added to Makefile in the commit.  It has passed three testports for me as well, unfortunately my qemu-user-static based ARM64 jail (on amd64 host, all 13.0-RELEASE-p5) bombs out trying to build ports-mgmt/pkg, so no joy cross-building it for now.
Comment 7 commit-hook freebsd_committer 2021-11-20 22:58:02 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=997bacb528ceba53b9e680dff833a0258d3bf917

commit 997bacb528ceba53b9e680dff833a0258d3bf917
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2021-11-20 10:19:22 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2021-11-20 22:55:58 +0000

    mail/fetchmail: update to 6.4.24 and block LibreSSL.

    Now really 6.4.24 and not a 6.4.25 WIP.

    fetchmail cannot legally be linked with LibreSSL,
    because there is no GPLv2 clause 2b exemption for
    LibreSSL, only for OpenSSL.

    Correct LICENSE and remove LICENSE_COMB.
    Add comment on FSF dynamic linking dynamically
    suggested by Corey Halpin in the approval.

    Remove LibreSSL patch.

    Related to:
    PR:             259214

    Update:
    PR:             259945
    MFH:            2021Q4

    Approved by:    chalpin@cs.wisc.edu (maintainer)

 mail/fetchmail/Makefile                    | 70 +++++++++++++++++-------------
 mail/fetchmail/distinfo                    |  6 +--
 mail/fetchmail/files/patch-LibreSSL (gone) | 14 ------
 mail/fetchmailconf/Makefile                | 21 +++++----
 4 files changed, 52 insertions(+), 59 deletions(-)
Comment 8 commit-hook freebsd_committer 2021-11-20 23:00:05 UTC
A commit in branch 2021Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=67f2fcbfde9e6cd493086c4858bf3e4d91480252

commit 67f2fcbfde9e6cd493086c4858bf3e4d91480252
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2021-11-20 10:19:22 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2021-11-20 22:59:18 +0000

    mail/fetchmail: update to 6.4.24 and block LibreSSL.

    fetchmail cannot legally be linked with LibreSSL,
    because there is no GPLv2 clause 2b exemption for
    LibreSSL, only for OpenSSL.

    Correct LICENSE and remove LICENSE_COMB.
    Add comment on FSF dynamic linking dynamically
    suggested by Corey Halpin in the approval.

    Remove LibreSSL patch.

    Related to:
    PR:             259214

    Update:
    PR:             259945
    MFH:            2021Q4

    Approved by:    chalpin@cs.wisc.edu (maintainer)

    (cherry picked from commit 997bacb528ceba53b9e680dff833a0258d3bf917)

 mail/fetchmail/Makefile     | 69 +++++++++++++++++++++++++--------------------
 mail/fetchmail/distinfo     |  6 ++--
 mail/fetchmailconf/Makefile | 21 +++++++-------
 3 files changed, 52 insertions(+), 44 deletions(-)