Bug 260037 - [REVIVE] lang/julia:
Summary: [REVIVE] lang/julia:
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/JuliaLang/julia/re...
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2021-11-24 23:20 UTC by Eric Reardon
Modified: 2021-11-25 09:21 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (rizor.reardon)


Attachments
lang/julia patches (121.22 KB, patch)
2021-11-24 23:20 UTC, Eric Reardon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Reardon 2021-11-24 23:20:04 UTC
Created attachment 229715 [details]
lang/julia patches

This is based on the deleted lang/julia10 from ports with modifications by me.

Poudriere testport:
    passing on FreeBSD 12.2-RELEASE amd64 with default OPTIONS
    passing on FreeBSD 12.2-RELEASE amd64 with all OPTIONS enabled
    passing on FreeBSD 13.0-RELEASE amd64 with default OPTIONS
    passing on FreeBSD 13.0-RELEASE amd64 with all OPTIONS enabled

I will have i386 working as soon as i can.
Other archs are not (yet) supported up stream for FreeBSD.
This is the third release candidate but the FreeBSD support is good.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2021-11-25 00:42:28 UTC
Thank you Eric. Can you in addition to the full patch already included, produce and attach a diff against the last git version of lang/julia10 so we can review the delta.

If you can confirm the port passes QA as well (portlint, poudriere at least), that'd also be great. #freebsd-ports on Libera.Chat IRC if you need help/support getting that running
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2021-11-25 00:43:12 UTC
Aaaand, I missed that QA had been confirmed, cancel last request (modulo the delta diff), apologies :)
Comment 3 Eric Reardon 2021-11-25 00:55:38 UTC
lang/julia10 was deleted back in the svn port days,
is there a way to make a git diff. 

https://www.freshports.org/lang/julia10/
Comment 4 Guangyuan Yang freebsd_committer 2021-11-25 04:04:16 UTC
There is already a review in progress - please consider collaborating there, or at least open a new review since this is a lengthy patch to review here.

https://reviews.freebsd.org/D29359
Comment 5 Eric Reardon 2021-11-25 04:33:35 UTC
(In reply to Guangyuan Yang from comment #4)
Oh sorry i had not seen that.
How do collaborate with them.
Comment 6 Guangyuan Yang freebsd_committer 2021-11-25 05:08:41 UTC
(In reply to Eric Reardon from comment #5)

After another look, the original review seems stale for a while. I suggest that the first thing to do is to create a Phabricator account if you haven't had one, and post your patch to a new review. Feel free to tag all relevant personnel so we could take a closer look.
Comment 7 Eric Reardon 2021-11-25 05:34:34 UTC
(In reply to Guangyuan Yang from comment #6)
Thank you, i will start in the morning.