Created attachment 229715 [details]
This is based on the deleted lang/julia10 from ports with modifications by me.
passing on FreeBSD 12.2-RELEASE amd64 with default OPTIONS
passing on FreeBSD 12.2-RELEASE amd64 with all OPTIONS enabled
passing on FreeBSD 13.0-RELEASE amd64 with default OPTIONS
passing on FreeBSD 13.0-RELEASE amd64 with all OPTIONS enabled
I will have i386 working as soon as i can.
Other archs are not (yet) supported up stream for FreeBSD.
This is the third release candidate but the FreeBSD support is good.
Thank you Eric. Can you in addition to the full patch already included, produce and attach a diff against the last git version of lang/julia10 so we can review the delta.
If you can confirm the port passes QA as well (portlint, poudriere at least), that'd also be great. #freebsd-ports on Libera.Chat IRC if you need help/support getting that running
Aaaand, I missed that QA had been confirmed, cancel last request (modulo the delta diff), apologies :)
lang/julia10 was deleted back in the svn port days,
is there a way to make a git diff.
There is already a review in progress - please consider collaborating there, or at least open a new review since this is a lengthy patch to review here.
(In reply to Guangyuan Yang from comment #4)
Oh sorry i had not seen that.
How do collaborate with them.
(In reply to Eric Reardon from comment #5)
After another look, the original review seems stale for a while. I suggest that the first thing to do is to create a Phabricator account if you haven't had one, and post your patch to a new review. Feel free to tag all relevant personnel so we could take a closer look.
(In reply to Guangyuan Yang from comment #6)
Thank you, i will start in the morning.